[Evolution-hackers] sync vs async in invokations of sa-learn
Not Zed
notzed@ximian.com
Wed, 11 Aug 2004 10:17:27 +0800
--=-gfELyDBI4Dhp5oV1o1BR
Content-Type: multipart/alternative; boundary="=-PeMs82l1L0DbxAo8hr5v"
--=-PeMs82l1L0DbxAo8hr5v
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
On Tue, 2004-08-10 at 18:17 +1000, Andrew Cowie wrote:
> I know that you hold up updates to the UI when processing and learning
> junk, and understand why.*
>
> However, it's obvious in evolution/mail/em-junk-filter.c that someone
> took enormous effort to separate the act of injecting messages vi sa-
> learn from having sa-learn rebuild it's databases. (ie, use of --no-
> rebuild when learning, and then later a call to sa-learn with --
> rebuild).
>
> It would seem that the later action [em_junk_sa_commit_reports()] could
> happen in the background asynchronously. There's no need for the UI to
> wait for that as well, is there?
Well there are definitely possibilities for improvement in the code. We
also wanted to batch up processing, although i can't remember if we
managed to do that either. Infact all of the sa-learn and commit-
reports could be sub-threaded since it is only the setting of the flags
and the like which is important to the ui, which only requires the test.
--
Michael Zucchi <notzed@ximian.com>
"born to die, live to work, it's all
downhill from here"
Novell's Evolution and Free Software
Developer
--=-PeMs82l1L0DbxAo8hr5v
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.1.19">
</HEAD>
<BODY>
On Tue, 2004-08-10 at 18:17 +1000, Andrew Cowie wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">I know that you hold up updates to the UI when processing and learning</FONT>
<FONT COLOR="#000000">junk, and understand why.*</FONT>
<FONT COLOR="#000000">However, it's obvious in evolution/mail/em-junk-filter.c that someone</FONT>
<FONT COLOR="#000000">took enormous effort to separate the act of injecting messages vi sa-</FONT>
<FONT COLOR="#000000">learn from having sa-learn rebuild it's databases. (ie, use of --no-</FONT>
<FONT COLOR="#000000">rebuild when learning, and then later a call to sa-learn with --</FONT>
<FONT COLOR="#000000">rebuild).</FONT>
<FONT COLOR="#000000">It would seem that the later action [em_junk_sa_commit_reports()] could</FONT>
<FONT COLOR="#000000">happen in the background asynchronously. There's no need for the UI to</FONT>
<FONT COLOR="#000000">wait for that as well, is there?</FONT>
</PRE>
</BLOCKQUOTE>
Well there are definitely possibilities for improvement in the code. We also wanted to batch up processing, although i can't remember if we managed to do that either. Infact all of the sa-learn and commit-reports could be sub-threaded since it is only the setting of the flags and the like which is important to the ui, which only requires the test.
<PRE>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
-- <BR>
<TABLE CELLSPACING="6">
<TR>
<TD>
<IMG SRC="cid:1092190387.4553.28.camel@lostzed.mmc.com.au" WIDTH="48" HEIGHT="48" ALIGN="top" ALT="" BORDER="0">
</TD>
<TD>
<B>Michael Zucchi</B> <<A HREF="mailto:notzed@ximian.com">notzed@ximian.com</A>><BR>
<I>"born to die, live to work, it's all downhill from here"</I><BR>
<TT>Novell's <A HREF="http://codeblogs.ximian.com/blogs/evolution/">Evolution</A> and <A HREF="http://www.gnu.org/philosophy/free-sw.html">Free Software</A> Developer</TT>
</TD>
</TR>
</TABLE>
</TD>
</TR>
</TABLE>
</PRE>
</BODY>
</HTML>
--=-PeMs82l1L0DbxAo8hr5v--
--=-gfELyDBI4Dhp5oV1o1BR
Content-ID: <1092190387.4553.28.camel@lostzed.mmc.com.au>
Content-Disposition: attachment; filename=zed-48.small.jpg
Content-Type: application/octet-stream; name=zed-48.small.jpg
Content-Transfer-Encoding: base64
/9j/4AAQSkZJRgABAQEASABIAAD/2wBDAA0JCgsKCA0LCgsODg0PEyAVExISEyccHhcgLikxMC4p
LSwzOko+MzZGNywtQFdBRkxOUlNSMj5aYVpQYEpRUk//2wBDAQ4ODhMREyYVFSZPNS01T09PT09P
T09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0//wAARCAAwADADASIA
AhEBAxEB/8QAGQAAAwEBAQAAAAAAAAAAAAAAAwQFAgYB/8QALhAAAgEDAgUEAQIHAAAAAAAAAQID
BBEhABIFEzFBURQigZEGYXE0UmJyobHx/8QAFwEBAQEBAAAAAAAAAAAAAAAABAMCAf/EAB0RAAID
AQEAAwAAAAAAAAAAAAABAgMREjEiMkH/2gAMAwEAAhEDEQA/AK8sEEq35nLaP3e1cW/m8kfdtAfh
824L7I1YFrnaRt8+L40U1ECxiGjLzSCocRYuQhubW7jIxrcFZRzU7q3sh3e8deWvX67/AKX0Xegi
TixevoZdxjhnkk2xBj2Z7DIA74Gs+kgpoaamPLllqE5yPuO4i1+nix7+NS3qatikPNZa+idmjLGx
YE+7r16DHgnTEtRWTVIraiknUrE42mJvYTY/IyfjT66YZjNzkzSSRTrEYTuz0tbpg6oV1V62op5G
3QhV9yn+7t8DXPDiZlaepq0AYIBGEFtuRc2/WwH7aroXho98jNG5RVa4wDYNbzqNsefqdcnmM0J0
pp1kKyRywsdpU46EX/19aT4ioWgmanATG0Mpvcd89750arjMg2L1DfQtnSixTMW5hO0ZBZsEg5t5
xodU+8fhit7jZz4ChQWS99U1lC0H8RNZx74xK2DkAG48ePOtU0UUsQLC6kki/wC+jqtMpeLapjYg
XJyNLcxyr1EUHaWaEspHXPbXVcNkUcCUOjvNv2kAdAehOkVo4LrDEFG9hcnPe+rlUsNNSenUIWkk
ZHfbflqFC475IvqdnyWaRsgl6MNwysp13y8uLG3cTk6LBwCmliFR6lw7XBKdMdj50t+X8RkWOnhV
rbnLfX/dUPx1ivAoTJnmFm+CdIVEIx6XpFQSZxVVH6KrkRRaAudn9I8HXhniSPcyC/ntqzxOjMNS
6uNyMbqT0I1Ogoad6pF5S23C4t1zqOa8Y7xbEDSxmesguHDId4DKQDjGqMqHmNLGygFnujAZF8DF
820/xYpQ8RWcRLtkBINuh6Ef5B0tNRH0L7UEjGzCVTZirDBGfJ+NasrcMf4CnLp6f//Z
--=-gfELyDBI4Dhp5oV1o1BR--