From charlie at nunit.com Thu Mar 1 08:11:55 2007 From: charlie at nunit.com (Charlie Poole) Date: Thu, 1 Mar 2007 08:11:55 -0500 Subject: [Mono-dev] SPAM-LOW: [Patch] ConfigurationFile should be relative to the ApplicationBase In-Reply-To: <583d4c740702220528g51a9d6ccw83ac8594ca59f333@mail.gmail.com> Message-ID: <008101c75c03$3512cbb0$75e7d70a@FERRARI> Hi Jamie, Due to problems with CVS, I didn't get your last fixes into the release candidate. They'll show up in RC2/Final, whichever is next. Charlie > -----Original Message----- > From: mono-devel-list-bounces at lists.ximian.com > [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf > Of Jamie Cansdale > Sent: Thursday, February 22, 2007 8:28 AM > To: Mono Development List > Subject: SPAM-LOW: [Mono-dev] [Patch] ConfigurationFile > should be relative to the ApplicationBase > > I recently hit an issue with Mono not being able to find my > .config files. My application was developed using .NET so > this is a discrepancy between Mono and .NET. AFAIK this > behavior isn't documented anywhere. > > AppDomainSetup setup = new AppDomainSetup(); > setup.ApplicationBase = "app_base"; setup.ConfigurationFile = > "blar.config"; > > .NET would look for the .config file at > 'app_base\blar.config'. Mono looks for the .config file in > the current directory. If the ApplicationBase isn't specified > in .NET a MemberAccessException is thrown when the > ConfigurationFile property is accessed (assuming it isn't an > absolute path). > > I've attached patches for unit tests and a "fix" for this. > This is my first patch so please let me know if I'm doing it right. > > Thanks, Jamie. > > -- > http://www.testdriven.net > http://weblogs.asp.net/nunitaddin > From Jeroen.Hoet at alcatel-lucent.be Thu Mar 1 07:29:22 2007 From: Jeroen.Hoet at alcatel-lucent.be (Jeroen.Hoet at alcatel-lucent.be) Date: Thu, 1 Mar 2007 13:29:22 +0100 Subject: [Mono-dev] Crosscompile mono on Powerquicc3 - mscorlib.dll invalid CIL Message-ID: Hello all, I'm trying to get Mono running on a Powerquicc3 (ppc core) processor for an embedded platform. As a crosscompiler we use eldk4 from http://www.denx.de First we crosscompiled the mono binaries for this host and second we compile mono native(x86) to have the mcs-compiler to compile the more higher layers of the mono-environment as descripbed in http://www.mono-project.com/Mono:ARM (but then for ppc). To get mono crosscompiled we generated the cpu-4g.h and inssel.h/inssel.c files on target using crosscompiled versions of genmdesc and monoburg. On the ppc we can run mono, where it gives us the help but nothing more. If we try to run: # mono helloworld.exe The file /opt/mono/lib/mscorlib.dll is an invalid CIL image What is the reason that we get this message and how can we create the correct dll's? I even tried using the libtool script for the cross environment using the native mcs-compiler. Because it is an embedded environment, we have to crosscompile things on a build machine so compiling mono on the powerquicc is not a good option. Thanks in advance. Regards, Jeroen ------- Configure options for crosscompiling: ./configure CC=ppc_85xx-gcc RANLIB=ppc_85xx-ranlib CPP=ppc_85xx-cpp AR=ppc_85xx-ar AS=ppc_85xx-as STRIP=ppc_85xx-strip LD=ppc_85xx-ld CXX=ppc_85xx-c++ GXX=ppc_85xx-g++ --with-tls=no --prefix=/opt/mono cv_mono_sizeof_sunpath=104 mono_cv_uscore=set --host=powerpc-ppc85xx-linux2.6.16 --disable-mcs-build From charlie at nunit.com Thu Mar 1 08:48:58 2007 From: charlie at nunit.com (Charlie Poole) Date: Thu, 1 Mar 2007 08:48:58 -0500 Subject: [Mono-dev] SPAM-LOW: [Patch] ConfigurationFile should berelative to the ApplicationBase In-Reply-To: <008101c75c03$3512cbb0$75e7d70a@FERRARI> Message-ID: <000401c75c08$5fb35330$75e7d70a@FERRARI> Sorry to hit the list with this - I replied to the wrong email. Charlie > -----Original Message----- > From: mono-devel-list-bounces at lists.ximian.com > [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf > Of Charlie Poole > Sent: Thursday, March 01, 2007 8:12 AM > To: 'Jamie Cansdale'; 'Mono Development List' > Subject: Re: [Mono-dev] SPAM-LOW: [Patch] ConfigurationFile > should berelative to the ApplicationBase > > Hi Jamie, > > Due to problems with CVS, I didn't get your last fixes into > the release candidate. They'll show up in RC2/Final, > whichever is next. > > Charlie > > > -----Original Message----- > > From: mono-devel-list-bounces at lists.ximian.com > > [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf > Of Jamie > > Cansdale > > Sent: Thursday, February 22, 2007 8:28 AM > > To: Mono Development List > > Subject: SPAM-LOW: [Mono-dev] [Patch] ConfigurationFile should be > > relative to the ApplicationBase > > > > I recently hit an issue with Mono not being able to find my .config > > files. My application was developed using .NET so this is a > > discrepancy between Mono and .NET. AFAIK this behavior isn't > > documented anywhere. > > > > AppDomainSetup setup = new AppDomainSetup(); > setup.ApplicationBase = > > "app_base"; setup.ConfigurationFile = "blar.config"; > > > > .NET would look for the .config file at > 'app_base\blar.config'. Mono > > looks for the .config file in the current directory. If the > > ApplicationBase isn't specified in .NET a MemberAccessException is > > thrown when the ConfigurationFile property is accessed (assuming it > > isn't an absolute path). > > > > I've attached patches for unit tests and a "fix" for this. > > This is my first patch so please let me know if I'm doing it right. > > > > Thanks, Jamie. > > > > -- > > http://www.testdriven.net > > http://weblogs.asp.net/nunitaddin > > > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > From pedro at sobota.net Thu Mar 1 09:42:37 2007 From: pedro at sobota.net (Pedro Sobota) Date: Thu, 01 Mar 2007 11:42:37 -0300 Subject: [Mono-dev] monodocs2html help with source In-Reply-To: <1172718765.12640.74.camel@melchior.magi> References: <45E42B69.9000009@sobota.net> <1172631328.12640.58.camel@melchior.magi> <45E593FF.7080108@sobota.net> <1172718765.12640.74.camel@melchior.magi> Message-ID: <45E6E65D.3050906@sobota.net> Hi > See tools/stylesheet.xsl. If a cref attribute is specified, then the > value of the cref attribute is used. If a langword attribute is used, > then the value of the langword attribute is used. > Right. I hadn't seen the langword match. From what I gather, the cref attribute makes for a link with the full type or member name as the text, whereas the langword is just output with no link. They seem to be mutually exclusive, so I can't link and specify text as well. Maybe for the Monodoc format they aren't, in which case this could be repaired for monodocs2html? Pedro -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 250 bytes Desc: OpenPGP digital signature Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/f9903b8d/attachment.bin From jit at occams.info Thu Mar 1 10:00:14 2007 From: jit at occams.info (Joshua Tauberer) Date: Thu, 01 Mar 2007 10:00:14 -0500 Subject: [Mono-dev] monodocs2html help with source In-Reply-To: <45E6E65D.3050906@sobota.net> References: <45E42B69.9000009@sobota.net> <1172631328.12640.58.camel@melchior.magi> <45E593FF.7080108@sobota.net> <1172718765.12640.74.camel@melchior.magi> <45E6E65D.3050906@sobota.net> Message-ID: <45E6EA7E.2080106@occams.info> Pedro Sobota wrote: > Hi >> See tools/stylesheet.xsl. If a cref attribute is specified, then the >> value of the cref attribute is used. If a langword attribute is used, >> then the value of the langword attribute is used. >> > Right. I hadn't seen the langword match. From what I gather, the cref > attribute makes for a link with the full type or member name as the > text, whereas the langword is just output with no link. They seem to be > mutually exclusive, so I can't link and specify text as well. Maybe for > the Monodoc format they aren't, in which case this could be repaired for > monodocs2html? They have different uses. langword is used to tag language keywords, like "null", "true", "false", etc. cref is to make a link to another section of the documentation. The thing to do would be to improve the method for how the text for 's are generated automatically, rather than add a way for the user to provide his own text. -- - Josh Tauberer http://razor.occams.info "Yields falsehood when preceded by its quotation! Yields falsehood when preceded by its quotation!" Achilles to Tortoise (in "G?del, Escher, Bach" by Douglas Hofstadter) From dev.malst at apsystems.it Thu Mar 1 10:30:25 2007 From: dev.malst at apsystems.it (APS) Date: Thu, 01 Mar 2007 16:30:25 +0100 Subject: [Mono-dev] Again on WebService Name Resolution Message-ID: <7.0.0.16.0.20070301161906.03181670@apsystems.it> Hi, I'm writing regarding problems described in this thread http://lists.ximian.com/pipermail/mono-devel-list/2006-December/021695.html I would like to remember it because if the Name Resolution is the real source of the problem it should be solved cause it seems to me a problem that can arise in many situation. Is not such a strange behaviour to have a server on a LAN natted by a proxy to an external IP address without a dns name. In this case the webservice (or at lest its test page) doesn't work. If you think that this is the real problem and it's still not solved I can add it to bugzilla, I ask fo it before to avoid adding an useless waist of time for developers. From pedro at sobota.net Thu Mar 1 11:31:30 2007 From: pedro at sobota.net (Pedro Sobota) Date: Thu, 01 Mar 2007 13:31:30 -0300 Subject: [Mono-dev] monodocs2html help with source In-Reply-To: <45E6EA7E.2080106@occams.info> References: <45E42B69.9000009@sobota.net> <1172631328.12640.58.camel@melchior.magi> <45E593FF.7080108@sobota.net> <1172718765.12640.74.camel@melchior.magi> <45E6E65D.3050906@sobota.net> <45E6EA7E.2080106@occams.info> Message-ID: <45E6FFE2.6010401@sobota.net> Hi > They have different uses. langword is used to tag language keywords, > like "null", "true", "false", etc. cref is to make a link to another > section of the documentation. > I was aware; I considered using langword like a link text attribute because I was in a hurry. > The thing to do would be to improve the method for how the text for cref=>'s are generated automatically, rather than add a way for the user > to provide his own text I thought that a means to define the text already existed, and it was what i.e. the Mono documentation was using. That not being the case, I agree with you. I'm going to see if I can make monodocs2html generate the link text like the Monodoc Browser does. Pedro -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 250 bytes Desc: OpenPGP digital signature Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/50608de3/attachment.bin From igorz at mainsoft.com Thu Mar 1 11:33:02 2007 From: igorz at mainsoft.com (Igor Zelmanovich) Date: Thu, 1 Mar 2007 08:33:02 -0800 Subject: [Mono-dev] [Patch] System.Web.UI.WebControls.DataList.cs Message-ID: Attached id patch fixes applying styles if ExtractTemplateRows=true. DataList has ApplyControlStyle method iterates through the nested table rows, and applies item style to them. Also DataListItem in RenderItem method iterates through the nested table rows to perform render. I removed ApplyControlStyle, and styles are applied in DataListItem.RenderItem. Regards, Igor Zelmanovich. igorz at mainsoft.com -------------- next part -------------- A non-text attachment was scrubbed... Name: DataList.patch Type: application/octet-stream Size: 3352 bytes Desc: DataList.patch Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/24043995/attachment.obj From tonyxgu at yahoo.com Thu Mar 1 13:09:15 2007 From: tonyxgu at yahoo.com (Tony Gu) Date: Thu, 1 Mar 2007 10:09:15 -0800 (PST) Subject: [Mono-dev] SqlConnection Pooling Problem? Message-ID: <21936.4596.qm@web90412.mail.mud.yahoo.com> I got problem to use SqlConnection in mono-1.2.3.1 (seems on pooling). It hangs on creating new SqlConnection(connectionString) if the "Min Pool Size" greater than 0. Here is my connectionStrings: If I change the "Min Pool Size" as "0", it can create the connection well, but only works the queries before close this connection (connection.Close()). The next time to use this connection (it is not null) will get the Exception "SQL Server does not exist or access denied.". If I restart the application it will execute the first (set) query(s). After close and reopen the connection, got same error. The same web application runs OK on the early vewrsion(mono-1.1.18) without the "Pool Size" in the Web.Config. If I take the "Pool Size" off the config, the behave is same as "Min Pool Size=0". Does anybody experience this problem? Tony ____________________________________________________________________________________ Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users. http://answers.yahoo.com/dir/?link=list&sid=396546091 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/756ddf65/attachment.html From tonyxgu at yahoo.com Thu Mar 1 14:42:07 2007 From: tonyxgu at yahoo.com (Tony Gu) Date: Thu, 1 Mar 2007 11:42:07 -0800 (PST) Subject: [Mono-dev] SqlConnection Pooling Problem? Message-ID: <428964.18198.qm@web90401.mail.mud.yahoo.com> Actually, this problem started from mono-1.2.1. It is OK on mono-1.2. I just tested same application on those. ----- Original Message ---- From: Tony Gu To: Mono Development List Sent: Thursday, March 1, 2007 10:09:15 AM Subject: [Mono-dev] SqlConnection Pooling Problem? I got problem to use SqlConnection in mono-1.2.3.1 (seems on pooling). It hangs on creating new SqlConnection(connectionString) if the "Min Pool Size" greater than 0. Here is my connectionStrings: If I change the "Min Pool Size" as "0", it can create the connection well, but only works the queries before close this connection (connection.Close()). The next time to use this connection (it is not null) will get the Exception "SQL Server does not exist or access denied.". If I restart the application it will execute the first (set) query(s). After close and reopen the connection, got same error. The same web application runs OK on the early vewrsion(mono-1.1.18) without the "Pool Size" in the Web.Config. If I take the "Pool Size" off the config, the behave is same as "Min Pool Size=0". Does anybody experience this problem? Tony Get your own web address. Have a HUGE year through Yahoo! Small Business. _______________________________________________ Mono-devel-list mailing list Mono-devel-list at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ____________________________________________________________________________________ 8:00? 8:25? 8:40? Find a flick in no time with the Yahoo! Search movie showtime shortcut. http://tools.search.yahoo.com/shortcuts/#news -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/014ec131/attachment.html From grendello at gmail.com Thu Mar 1 21:41:20 2007 From: grendello at gmail.com (Marek Habersack) Date: Fri, 2 Mar 2007 03:41:20 +0100 Subject: [Mono-dev] [PATCH] Improvements to Mono assembly shadow-copying Message-ID: <20070302034120.4dd23bf6@beowulf.thanes.org> Hello, The attached diff implements the following improvements: 1. When copying an assembly, it also makes copies of the associated .mdb and .config files, if found. 2. The shadow copies are created in a subdirectory below the app domain's dynamic base directory. The directory names are generated based on the assembly name hash, assembly location hash and the combination of the two. The assemblies will no longer be called shadow-XXXXXX, they will instead retain their original name. This mimics the way MS .Net works please review, thanks marek -------------- next part -------------- A non-text attachment was scrubbed... Name: shadow_copy_siblings.diff Type: text/x-patch Size: 4786 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/6d77ec51/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/6d77ec51/attachment-0001.bin From moath2 at yahoo.com Fri Mar 2 00:21:41 2007 From: moath2 at yahoo.com (Muath A. Khalaf) Date: Thu, 1 Mar 2007 21:21:41 -0800 (PST) Subject: [Mono-dev] Does JIT produce code with frame pointer Message-ID: <364446.35572.qm@web51414.mail.yahoo.com> Hi, 1- I want to ask if JIT produces code that has a frame pointer i.e. something similar to what you get when you omit the "-fomit-frame-pointer" option with gcc. 2- Is it correct that: a mono single threaded program has only two runtime stacks one for the application thread and the other for the GC thread. This means that when a managed method calls an internal mono method (icall) then on the app runtime stack I will have the managed method frame along with the icall frame on top of it (or below) of course with the wrapper in between. This is important as I am trying to integrate OProfile with mono and want to understand the stacks that should be sampled by OProfile to test them. Regards ____________________________________________________________________________________ Expecting? Get great news right away with email Auto-Check. Try the Yahoo! Mail Beta. http://advision.webevents.yahoo.com/mailbeta/newmail_tools.html -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070301/2a6f40f5/attachment.html From massi at ximian.com Fri Mar 2 02:24:54 2007 From: massi at ximian.com (Massimiliano Mantione) Date: Fri, 02 Mar 2007 08:24:54 +0100 Subject: [Mono-dev] Does JIT produce code with frame pointer In-Reply-To: <364446.35572.qm@web51414.mail.yahoo.com> References: <364446.35572.qm@web51414.mail.yahoo.com> Message-ID: <1172820294.4238.13.camel@matrix.ximian.com> On Thu, 2007-03-01 at 21:21 -0800, Muath A. Khalaf wrote: > 1- I want to ask if JIT produces code that has a frame pointer i.e. > something similar to what you get when you omit the "-fomit-frame-pointer" > option with gcc. Yes, we use the frame pointer. > 2- Is it correct that: a mono single threaded program has only two > runtime > stacks one for the application thread and the other for the GC thread. > This > means that when a managed method calls an internal mono method (icall) > then > on the app runtime stack I will have the managed method frame along > with the > icall frame on top of it (or below) of course with the wrapper in > between. There can be a finalizer thread, too (if it's not disabled). > This is important as I am trying to integrate OProfile with mono and > want > to understand the stacks that should be sampled by OProfile to test > them. Interesting! But why should OProfile ignore the gc and finaliser stacks-threads? IMHO, one of the great things of OProfile is that it's a system-level profiler, which samples everything... what if in my application those threads play an important role performance-wise? Of course it's possible I'm missing something... However, I had the impression that the only thing that OProfile needs to know is the mapping from memory regions to methods in the source code. BTW, are you basing your work on the OProfile/Java integration done by IBM, or are you restarting from scratch? Ciao, Massi From anagappan at novell.com Fri Mar 2 02:52:16 2007 From: anagappan at novell.com (A Nagappan) Date: Fri, 02 Mar 2007 00:52:16 -0700 Subject: [Mono-dev] SqlConnection Pooling Problem? Message-ID: <45E825080200004400009ABA@lucius.provo.novell.com> Hi, Could you please file a bug on this with a sample test case to reproduce this bug. http://bugzilla.ximian.com/enter_bug.cgi?product=Mono%3A%20Class%20Libraries under Sys.Data.SqlClient component. Thanks Nagappan Nagappan A Linux Desktop Testing Project - http://ldtp.freedesktop.org http://nagappanal.blogspot.com Novell, Inc. SUSE? Linux Enterprise 10 Your Linux is ready? http://www.novell.com/linux >>> Tony Gu 03/02/07 1:12 AM >>> Actually, this problem started from mono-1.2.1. It is OK on mono-1.2. I just tested same application on those. ----- Original Message ---- From: Tony Gu To: Mono Development List Sent: Thursday, March 1, 2007 10:09:15 AM Subject: [Mono-dev] SqlConnection Pooling Problem? I got problem to use SqlConnection in mono-1.2.3.1 (seems on pooling). It hangs on creating new SqlConnection(connectionString) if the "Min Pool Size" greater than 0. Here is my connectionStrings: If I change the "Min Pool Size" as "0", it can create the connection well, but only works the queries before close this connection (connection.Close()). The next time to use this connection (it is not null) will get the Exception "SQL Server does not exist or access denied.". If I restart the application it will execute the first (set) query(s). After close and reopen the connection, got same error. The same web application runs OK on the early vewrsion(mono-1.1.18) without the "Pool Size" in the Web.Config. If I take the "Pool Size" off the config, the behave is same as "Min Pool Size=0". Does anybody experience this problem? Tony Get your own web address. Have a HUGE year through Yahoo! Small Business. _______________________________________________ Mono-devel-list mailing list Mono-devel-list at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ____________________________________________________________________________________ 8:00? 8:25? 8:40? Find a flick in no time with the Yahoo! Search movie showtime shortcut. http://tools.search.yahoo.com/shortcuts/#news From denisraytek at yahoo.com Fri Mar 2 07:34:26 2007 From: denisraytek at yahoo.com (Dennis Hayes) Date: Fri, 2 Mar 2007 04:34:26 -0800 (PST) Subject: [Mono-dev] Bug in Moma? In-Reply-To: Message-ID: <669927.5956.qm@web39608.mail.mud.yahoo.com> Here the same function is listed as niex, and as miss. This can from one cut and paste, there was nothing inbetween these two functions in the Moma report. I can provide the dll if needed. Should I file a bugzilla report? Am I missing something obvious? thanks, Dennis Methods called that throw NotImplementedException Calling Method Mono method that throws NotImplementedException Class DotNetNuke.Security.Authentication.ADSI.Search: void .ctor(DirectoryEntry, string, string) SortOption DirectorySearcher.get_Sort() Methods called marked with [MonoTodo] Calling Method Method with [MonoTodo] Reason Class DotNetNuke.Security.Authentication.ADSI.Search: void .ctor(DirectoryEntry, string, string) SortOption DirectorySearcher.get_Sort() Not Specified --------------------------------- Get your own web address. Have a HUGE year through Yahoo! Small Business. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/fcde2136/attachment.html From robertj at gmx.net Fri Mar 2 08:22:28 2007 From: robertj at gmx.net (Robert Jordan) Date: Fri, 02 Mar 2007 14:22:28 +0100 Subject: [Mono-dev] Bug in Moma? In-Reply-To: <669927.5956.qm@web39608.mail.mud.yahoo.com> References: <669927.5956.qm@web39608.mail.mud.yahoo.com> Message-ID: Dennis Hayes wrote: > Here the same function is listed as niex, and as miss. This can from > one cut and paste, there was nothing inbetween these two functions in > the Moma report. I can provide the dll if needed. Should I file a > bugzilla report? Am I missing something obvious? Well, that method is both tagged with MonoTODO *and* it also throws NIE. That's actually an useful information, because MonoTODO alone doesn't imply that a method can't be used at all (it could be also a warning for a small issue), whereas throwing NIE is a sentence of death. Robert > thanks, Dennis > > > Methods called that throw NotImplementedException Calling > Method Mono method that throws NotImplementedException Class > DotNetNuke.Security.Authentication.ADSI.Search: void > .ctor(DirectoryEntry, string, string) SortOption > DirectorySearcher.get_Sort() > > Methods called marked with [MonoTodo] Calling Method Method > with [MonoTodo] Reason Class > DotNetNuke.Security.Authentication.ADSI.Search: void > .ctor(DirectoryEntry, string, string) SortOption > DirectorySearcher.get_Sort() Not Specified > > > > --------------------------------- Get your own web address. Have a > HUGE year through Yahoo! Small Business. > > > ------------------------------------------------------------------------ > > > _______________________________________________ Mono-devel-list > mailing list Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list From grendello at gmail.com Fri Mar 2 08:55:47 2007 From: grendello at gmail.com (Marek Habersack) Date: Fri, 2 Mar 2007 14:55:47 +0100 Subject: [Mono-dev] [PATCH] Improvements to Mono assembly shadow-copying In-Reply-To: <20070302034120.4dd23bf6@beowulf.thanes.org> References: <20070302034120.4dd23bf6@beowulf.thanes.org> Message-ID: <20070302145547.23726462@beowulf.thanes.org> On Fri, 2 Mar 2007 03:41:20 +0100, Marek Habersack scribbled: > Hello, > > The attached diff implements the following improvements: > > 1. When copying an assembly, it also makes copies of the associated .mdb > and .config files, if found. > > 2. The shadow copies are created in a subdirectory below the app domain's > dynamic base directory. The directory names are generated based on the > assembly name hash, assembly location hash and the combination of the two. The > assemblies will no longer be called shadow-XXXXXX, they will instead retain > their original name. This mimics the way MS .Net works Attached is an updated version of the diff. Please review, marek -------------- next part -------------- A non-text attachment was scrubbed... Name: shadow_copy_siblings.diff Type: text/x-patch Size: 4716 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/ae63f6a8/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/ae63f6a8/attachment-0001.bin From moath2 at yahoo.com Fri Mar 2 22:27:11 2007 From: moath2 at yahoo.com (Muath A. Khalaf) Date: Fri, 2 Mar 2007 19:27:11 -0800 (PST) Subject: [Mono-dev] Does JIT produce code with frame pointer Message-ID: <235641.24431.qm@web51412.mail.yahoo.com> Hi, For OProfile I am just implementing part of the project as a graduate course project. I am implementing the memory map from mono JIT to OProfile. How OProfile handles this data and match it with the anonymous methods it has, is implemented by someone else in the Lab and still not complete yet. Now we are able to get reports about mono apps using opreport and it will give us each method sampled with its fully qualified name. The problem is with callgraphs. OProfile gave us the call graphs for mono itself (runtime, GC) but always gives us the name of the managed methods isolated i.e. alone. Here is a sample form the output for a recursive mono benchmark. As you can see we have a problem when it comes to JIT.App which is the managed code. But the mono methods are well. So this looks like as if Ack, Fib and Tak are running separately in different stacks and also isolated from the mono runtime itself. Otherwise we should have at least seen Main method as it calls each one of them respectively. May be the problem is related to our OProfile patch but I just wanted to avoid any surprises:) Thanks. ------------- OUTPUT --------------------- samples % image name symbol name ------------------------------------------------------------------------------- 4099 42.2490 JIT.App recursive:Ack (int,int) 4099 100.000 JIT.App recursive:Ack (int,int) [self] ------------------------------------------------------------------------------- 3145 32.4160 JIT.App recursive:Fib (double) 3145 100.000 JIT.App recursive:Fib (double) [self] ------------------------------------------------------------------------------- 2373 24.4589 JIT.App recursive:Tak (int,int,int) 2373 100.000 JIT.App recursive:Tak (int,int,int) [self] ------------------------------------------------------------------------------- 1 4.5455 mono mono_get_method_from_token 2 9.0909 mono mono_metadata_get_param_attrs 3 13.6364 mono mono_metadata_load_generic_params 16 72.7273 mono mono_metadata_get_generic_param_row 22 0.2268 mono mono_metadata_decode_row 22 100.000 mono mono_metadata_decode_row [self] . . . . ----- Original Message ---- From: Massimiliano Mantione To: Muath A. Khalaf Cc: mono-devel-list at lists.ximian.com Sent: Thursday, March 1, 2007 11:24:54 PM Subject: Re: [Mono-dev] Does JIT produce code with frame pointer On Thu, 2007-03-01 at 21:21 -0800, Muath A. Khalaf wrote: > 1- I want to ask if JIT produces code that has a frame pointer i.e. > something similar to what you get when you omit the "-fomit-frame-pointer" > option with gcc. Yes, we use the frame pointer. > 2- Is it correct that: a mono single threaded program has only two > runtime > stacks one for the application thread and the other for the GC thread. > This > means that when a managed method calls an internal mono method (icall) > then > on the app runtime stack I will have the managed method frame along > with the > icall frame on top of it (or below) of course with the wrapper in > between. There can be a finalizer thread, too (if it's not disabled). > This is important as I am trying to integrate OProfile with mono and > want > to understand the stacks that should be sampled by OProfile to test > them. Interesting! But why should OProfile ignore the gc and finaliser stacks-threads? IMHO, one of the great things of OProfile is that it's a system-level profiler, which samples everything... what if in my application those threads play an important role performance-wise? Of course it's possible I'm missing something... However, I had the impression that the only thing that OProfile needs to know is the mapping from memory regions to methods in the source code. BTW, are you basing your work on the OProfile/Java integration done by IBM, or are you restarting from scratch? Ciao, Massi ____________________________________________________________________________________ Want to start your own business? Learn how on Yahoo! Small Business. http://smallbusiness.yahoo.com/r-index -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070302/2c4f89eb/attachment.html From charlie at pooleconsulting.com Sat Mar 3 09:30:18 2007 From: charlie at pooleconsulting.com (Charlie Poole) Date: Sat, 3 Mar 2007 09:30:18 -0500 Subject: [Mono-dev] ANN: NUnit 2.4 Release Candidate Message-ID: <000801c75da0$77fe3f10$32e7d70a@FERRARI> Hi folks, The NUnit 2.4 Release Candidate is available. You can get it at http://nunit.com/nunit/?p=download It has quite a lot of new features, which you can review at http://nunit.com/nunit/?p=releaseNotes&r=2.4 Charlie From denisraytek at yahoo.com Sun Mar 4 18:57:04 2007 From: denisraytek at yahoo.com (Dennis Hayes) Date: Sun, 4 Mar 2007 15:57:04 -0800 (PST) Subject: [Mono-dev] Patch for Math.cs In-Reply-To: Message-ID: <183219.24413.qm@web39609.mail.mud.yahoo.com> This is a minor clean up of Math.cs. Basicly, in the methods that use MidpointRounding Mode, it moves the check for a valid mode to the end of the method. Since the mode is checked in the method, doing this eliminates the extra check. Also, the check should never fail, since an enum is being passed in. This will make the code a little faster. I don't have svn access setup, so I need someone to check this in also. I did not include any tests, because this should not have added or modifyed anything testable. Should I do anything elseor do anything differently? Would this be better as a switch? Thanks, Dennis --------------------------------- Need a quick answer? Get one in minutes from people who know. Ask your question on Yahoo! Answers. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070304/16a93b3b/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: math.diff Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070304/16a93b3b/attachment.pl From alan.mcgovern at gmail.com Sun Mar 4 19:02:40 2007 From: alan.mcgovern at gmail.com (Alan McGovern) Date: Mon, 5 Mar 2007 00:02:40 +0000 Subject: [Mono-dev] Patch for Math.cs In-Reply-To: <183219.24413.qm@web39609.mail.mud.yahoo.com> References: <183219.24413.qm@web39609.mail.mud.yahoo.com> Message-ID: <117799f00703041602s17916e28u993ccdbb21c87a2e@mail.gmail.com> Just out of interest, could you check the performance of the method if you change code patterns like: if (value > 0) return Floor (value + 0.5); else return Ceiling (value - 0.5); to: return (value > 0) ? Floor(value+0.5) : Ceiling(value - 0.5); When i was profiling stuff before i think there was a performance boost when using the turnary form, I may be wrong though. If it does turn out to be faster, you could make that change to. If it isn't, no worries. Alan. On 3/4/07, Dennis Hayes wrote: > > This is a minor clean up of Math.cs. > Basicly, in the methods that use MidpointRounding Mode, it moves the check > for a valid mode to the end of the method. > > Since the mode is checked in the method, doing this eliminates the extra > check. Also, the check should never fail, since an enum is being passed in. > This will make the code a little faster. > > I don't have svn access setup, so I need someone to check this in also. > > I did not include any tests, because this should not have added or > modifyed anything testable. > > Should I do anything elseor do anything differently? > Would this be better as a switch? > Thanks, > Dennis > > ------------------------------ > Need a quick answer? Get one in minutes from people who know. Ask your > question on Yahoo! Answers. > --0-164504892-1173052624=:24413-- > > > Index: Math.cs > =================================================================== > --- Math.cs (revision 73696) > +++ Math.cs (working copy) > @@ -373,27 +373,27 @@ > [MonoTODO ("Not implemented")] > public static decimal Round (decimal d, MidpointRounding > mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" > + mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (d); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.AwayFromZero) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode > + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > [MonoTODO ("Not implemented")] > public static decimal Round (decimal d, int decimals, > MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" > + mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (d, decimals); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.AwayFromZero) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode > + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > #endif > > - [MethodImplAttribute (MethodImplOptions.InternalCall)] > + [MethodImplAttribute (MethodImplOptions.InternalCall)] > public extern static double Round (double d); > > public static double Round (double value, int digits) > @@ -411,26 +411,25 @@ > #if NET_2_0 > public static double Round (double value, MidpointRounding > mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" > + mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (value); > if (value > 0) > return Floor (value + 0.5); > else > return Ceiling (value - 0.5); > + > + throw new ArgumentException ("The value '" + mode > + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > [MonoTODO ("Not implemented")] > public static double Round (double value, int digits, > MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" > + mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > - if (mode == MidpointRounding.ToEven) > + if (mode == MidpointRounding.ToEven) > return Round (value, digits); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.ToEven) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode > + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > public static double Truncate (double d) > @@ -454,7 +453,7 @@ > } > #endif > > - public static int Sign (decimal value) > + public static int Sign (decimal value) > { > if (value > 0) return 1; > return (value == 0)? 0: -1; > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/292dd116/attachment.html From cetin.sert at gmail.com Sun Mar 4 19:47:44 2007 From: cetin.sert at gmail.com (Cetin Sert) Date: Mon, 5 Mar 2007 01:47:44 +0100 Subject: [Mono-dev] Patch for Math.cs In-Reply-To: <117799f00703041602s17916e28u993ccdbb21c87a2e@mail.gmail.com> References: <183219.24413.qm@web39609.mail.mud.yahoo.com> <117799f00703041602s17916e28u993ccdbb21c87a2e@mail.gmail.com> Message-ID: <45eb68b9.4b8fb97b.437c.5d08@mx.google.com> Hi I just checked the IL codes of these methods: private static bool TestIf(int value) { if (value > 0) return true; else return false; } private static bool TestTurnary(int value) { return value > 0 ? true : false; } and got these from Lutz Roeder?s famous .NET Reflector (5.0.5.0): .method private hidebysig static bool TestIf( int32 'value') cil managed { .maxstack 8 L_0000: ldarg.0 L_0001: ldc.i4.0 L_0002: ble.s L_0006 L_0004: ldc.i4.1 L_0005: ret L_0006: ldc.i4.0 L_0007: ret } .method private hidebysig static bool TestTurnary( int32 'value') cil managed { .maxstack 8 L_0000: ldarg.0 L_0001: ldc.i4.0 L_0002: bgt.s L_0006 L_0004: ldc.i4.0 L_0005: ret L_0006: ldc.i4.1 L_0007: ret } As you can see, there is nothing that might cause a performance difference. It?s only the order of things that?s different. From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Alan McGovern Sent: Montag, 5. M?rz 2007 01:03 To: Dennis Hayes Cc: mono-devel-list at lists.ximian.com Subject: Re: [Mono-dev] Patch for Math.cs Just out of interest, could you check the performance of the method if you change code patterns like: if (value > 0) return Floor (value + 0.5); else return Ceiling (value - 0.5); to: return (value > 0) ? Floor(value+0.5) : Ceiling(value - 0.5); When i was profiling stuff before i think there was a performance boost when using the turnary form, I may be wrong though. If it does turn out to be faster, you could make that change to. If it isn't, no worries. Alan. On 3/4/07, Dennis Hayes wrote: This is a minor clean up of Math.cs. Basicly, in the methods that use MidpointRounding Mode, it moves the check for a valid mode to the end of the method. Since the mode is checked in the method, doing this eliminates the extra check. Also, the check should never fail, since an enum is being passed in. This will make the code a little faster. I don't have svn access setup, so I need someone to check this in also. I did not include any tests, because this should not have added or modifyed anything testable. Should I do anything elseor do anything differently? Would this be better as a switch? Thanks, Dennis _____ Need a quick answer? Get one in minutes from people who know. Ask your question on Yahoo! Answers . --0-164504892-1173052624=:24413-- Index: Math.cs =================================================================== --- Math.cs (revision 73696) +++ Math.cs (working copy) @@ -373,27 +373,27 @@ [MonoTODO ("Not implemented")] public static decimal Round (decimal d, MidpointRounding mode) { - if ((mode != MidpointRounding.ToEven ) && (mode != MidpointRounding.AwayFromZero)) - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); - if (mode == MidpointRounding.ToEven) return Round (d); - throw new NotImplementedException (); + if (mode == MidpointRounding.AwayFromZero) + throw new NotImplementedException (); + + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); } [MonoTODO ("Not implemented")] public static decimal Round (decimal d, int decimals, MidpointRounding mode) { - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); - if (mode == MidpointRounding.ToEven) return Round (d, decimals); - throw new NotImplementedException (); + if (mode == MidpointRounding.AwayFromZero) + throw new NotImplementedException (); + + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); } #endif - [MethodImplAttribute (MethodImplOptions.InternalCall)] + [MethodImplAttribute (MethodImplOptions.InternalCall)] public extern static double Round (double d); public static double Round (double value, int digits) @@ -411,26 +411,25 @@ #if NET_2_0 public static double Round (double value, MidpointRounding mode) { - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); - if (mode == MidpointRounding.ToEven) return Round (value); if (value > 0) return Floor (value + 0.5); else return Ceiling (value - 0.5); + + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); } [MonoTODO ("Not implemented")] public static double Round (double value, int digits, MidpointRounding mode) { - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); - - if (mode == MidpointRounding.ToEven) + if (mode == MidpointRounding.ToEven) return Round (value, digits); - throw new NotImplementedException (); + if (mode == MidpointRounding.ToEven) + throw new NotImplementedException (); + + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); } public static double Truncate (double d) @@ -454,7 +453,7 @@ } #endif - public static int Sign (decimal value) + public static int Sign (decimal value) { if (value > 0) return 1; return (value == 0)? 0: -1; _______________________________________________ Mono-devel-list mailing list Mono-devel-list at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/c958125a/attachment.html From felipe.lessa at gmail.com Sun Mar 4 20:09:14 2007 From: felipe.lessa at gmail.com (Felipe Almeida Lessa) Date: Sun, 4 Mar 2007 22:09:14 -0300 Subject: [Mono-dev] Patch for Math.cs In-Reply-To: <183219.24413.qm@web39609.mail.mud.yahoo.com> References: <183219.24413.qm@web39609.mail.mud.yahoo.com> Message-ID: I'm not a Mono dev so I may be wrong, but see my two comments below. On 3/4/07, Dennis Hayes wrote: > @@ -411,26 +411,25 @@ > #if NET_2_0 > public static double Round (double value, MidpointRounding > mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + > mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (value); > if (value > 0) > return Floor (value + 0.5); > else > return Ceiling (value - 0.5); > + > + throw new ArgumentException ("The value '" + mode + > "' is not valid for this usage of the type MidpointRounding.", "mode"); > } Is it just me or this throw is non-reachable? The if clause just before it should catch every possible paths (that could lead to it). > [MonoTODO ("Not implemented")] > public static double Round (double value, int digits, > MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != > MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + > mode + "' is not valid for this usage of the type MidpointRounding.", > "mode"); > - > - if (mode == MidpointRounding.ToEven) > + if (mode == MidpointRounding.ToEven) > return Round (value, digits); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.ToEven) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode + > "' is not valid for this usage of the type MidpointRounding.", "mode"); > } Two checks to MidpointRounding.ToEven? The second one is unreachable as well (although I don't know if the compiler is clever enough to discover that). I suppose you meant MidpointRounding.AwayFromZero on the second if. HTH, -- Felipe. From alan.mcgovern at gmail.com Sun Mar 4 20:19:31 2007 From: alan.mcgovern at gmail.com (Alan McGovern) Date: Mon, 5 Mar 2007 01:19:31 +0000 Subject: [Mono-dev] Patch for Math.cs In-Reply-To: References: <183219.24413.qm@web39609.mail.mud.yahoo.com> Message-ID: <117799f00703041719i5e86a031m62428d6e8abc0d90@mail.gmail.com> Forgive the terrible indenting on the code: http://pastebin.ca/381736 But that indicates a huge difference between performance when using turnary as opposed to if/else. Turns out if/else is much much faster. What the hell? Alan. On 3/5/07, Felipe Almeida Lessa wrote: > > I'm not a Mono dev so I may be wrong, but see my two comments below. > > On 3/4/07, Dennis Hayes wrote: > > @@ -411,26 +411,25 @@ > > #if NET_2_0 > > public static double Round (double value, > MidpointRounding > > mode) > > { > > - if ((mode != MidpointRounding.ToEven) && (mode > != > > MidpointRounding.AwayFromZero)) > > - throw new ArgumentException ("The value > '" + > > mode + "' is not valid for this usage of the type MidpointRounding.", > > "mode"); > > - > > if (mode == MidpointRounding.ToEven) > > return Round (value); > > if (value > 0) > > return Floor (value + 0.5); > > else > > return Ceiling (value - 0.5); > > + > > + throw new ArgumentException ("The value '" + > mode + > > "' is not valid for this usage of the type MidpointRounding.", "mode"); > > } > > > Is it just me or this throw is non-reachable? The if clause just > before it should catch every possible paths (that could lead to it). > > > > > [MonoTODO ("Not implemented")] > > public static double Round (double value, int digits, > > MidpointRounding mode) > > { > > - if ((mode != MidpointRounding.ToEven) && (mode > != > > MidpointRounding.AwayFromZero)) > > - throw new ArgumentException ("The value > '" + > > mode + "' is not valid for this usage of the type MidpointRounding.", > > "mode"); > > - > > - if (mode == MidpointRounding.ToEven) > > + if (mode == MidpointRounding.ToEven) > > return Round (value, digits); > > - throw new NotImplementedException (); > > + if (mode == MidpointRounding.ToEven) > > + throw new NotImplementedException (); > > + > > + throw new ArgumentException ("The value '" + > mode + > > "' is not valid for this usage of the type MidpointRounding.", "mode"); > > } > > > Two checks to MidpointRounding.ToEven? The second one is unreachable > as well (although I don't know if the compiler is clever enough to > discover that). I suppose you meant MidpointRounding.AwayFromZero on > the second if. > > > HTH, > > -- > Felipe. > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/26fc2b08/attachment.html From denisraytek at yahoo.com Sun Mar 4 22:45:08 2007 From: denisraytek at yahoo.com (Dennis Hayes) Date: Sun, 4 Mar 2007 19:45:08 -0800 (PST) Subject: [Mono-dev] Math.cs patch correction In-Reply-To: Message-ID: <568148.78516.qm@web39605.mail.mud.yahoo.com> This again cleans up the 2.0 rounding methods that use the MidpointRounding enum options. It will give a small speed increase by moving a test that should never fail from the top of the method to the bottom of the method, where is should never need to be executed. My next task is to implment the missing methods. Do I need to do anything more or different? Dennis --------------------------------- Finding fabulous fares is fun. Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070304/ebe3fed7/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: math.diff Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070304/ebe3fed7/attachment.pl From atsushi at ximian.com Mon Mar 5 01:08:43 2007 From: atsushi at ximian.com (Atsushi Eno) Date: Mon, 05 Mar 2007 15:08:43 +0900 Subject: [Mono-dev] [PATCH] System.Web.Services: throw on protocol mismatch In-Reply-To: References: Message-ID: <45EBB3EB.6020609@ximian.com> Hi, I'm in doubt that it is the correct way to filter errors out. Do you have any test case that needs this? Atsushi Eno Konstantin Triger wrote: > Hello all, > > .Net throws on soap version mismatch. > Please review the attached patch fixing this. > > Regards, > Konstantin Triger > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list From atsushi at ximian.com Mon Mar 5 01:13:21 2007 From: atsushi at ximian.com (Atsushi Eno) Date: Mon, 05 Mar 2007 15:13:21 +0900 Subject: [Mono-dev] [PATCH] System.Web.Services: remove extra documentation item(s) from wsdl In-Reply-To: References: Message-ID: <45EBB501.7090005@ximian.com> Hi Kosta, Konstantin Triger wrote: > Hi Eno, > > The fix works for me, but it's still not good: > > if (o119 is XmlElement) { > if ((o119.LocalName == "documentation" && o119.NamespaceURI == "http://schemas.xmlsoap.org/wsdl/")) { > } > else o119.WriteTo (Writer); > WriteElementLiteral (o119, "", "", false, true); > }else > throw CreateUnknownAnyElementException (o119.Name, o119.NamespaceURI); > > So currently it will print twice if the LocalName != "documentation"... > > What it should be is write once if LocalName && NamespaceURI are fine (can be several possibilities - for each XmlAnyElement) or throw. Well, I thought that there is no other case than "wsdl:documentation" that could pass there (or I'm likely misunderstanding what the generated code does). In which case will it output things twice? Atsushi Eno From kostat at mainsoft.com Mon Mar 5 02:57:36 2007 From: kostat at mainsoft.com (Konstantin Triger) Date: Sun, 4 Mar 2007 23:57:36 -0800 Subject: [Mono-dev] [PATCH] System.Web.Services: remove extra documentation item(s) from wsdl In-Reply-To: <45EBB501.7090005@ximian.com> Message-ID: Hi Eno, That's right, in Sys.Web.Services exists only "wsdl:documentation" case. But since you make a change in the generator code, the fix should be generic. What I mean is that if someone outside the Sys.Web.Services will create such a code and pass something different to "wsdl:documentation", he will get results different than on .net. Regards, Kosta > -----Original Message----- > From: Atsushi Eno [mailto:atsushi at ximian.com] > Sent: Monday, March 05, 2007 8:13 AM > To: Konstantin Triger > Cc: Mono Development List > Subject: Re: [Mono-dev] [PATCH] System.Web.Services: remove extra > documentation item(s) from wsdl > > Hi Kosta, > > Konstantin Triger wrote: > > Hi Eno, > > > > The fix works for me, but it's still not good: > > > > if (o119 is XmlElement) { > > if ((o119.LocalName == "documentation" && o119.NamespaceURI == > "http://schemas.xmlsoap.org/wsdl/")) { > > } > > else o119.WriteTo (Writer); > > WriteElementLiteral (o119, "", "", false, true); > > }else > > throw CreateUnknownAnyElementException (o119.Name, o119.NamespaceURI); > > > > So currently it will print twice if the LocalName != "documentation"... > > > > What it should be is write once if LocalName && NamespaceURI are fine > (can be several possibilities - for each XmlAnyElement) or throw. > > Well, I thought that there is no other case than "wsdl:documentation" > that could pass there (or I'm likely misunderstanding what the > generated code does). In which case will it output things twice? > > Atsushi Eno From kostat at mainsoft.com Mon Mar 5 03:04:59 2007 From: kostat at mainsoft.com (Konstantin Triger) Date: Mon, 5 Mar 2007 00:04:59 -0800 Subject: [Mono-dev] [PATCH] System.Web.Services: throw on protocol mismatch In-Reply-To: <45EBB3EB.6020609@ximian.com> Message-ID: Hi Eno, Yep, I did the following: 1. Create a HelloWorld WS, suppress HttpSoap using configuration and deploy. 2. Get a reference to this service. 3. Go to the WS, suppress HttpSoap12 and redeploy. 4. Run the client without updating the reference. 5. Do the same suppressing first HttpSoap12 and then HttpSoap. Regards, Kosta > -----Original Message----- > From: Atsushi Eno [mailto:atsushi at ximian.com] > Sent: Monday, March 05, 2007 8:09 AM > To: Konstantin Triger > Cc: mono-devel-list at ximian.com > Subject: Re: [Mono-dev] [PATCH] System.Web.Services: throw on protocol > mismatch > > Hi, > > I'm in doubt that it is the correct way to filter errors out. Do > you have any test case that needs this? > > Atsushi Eno > > Konstantin Triger wrote: > > Hello all, > > > > .Net throws on soap version mismatch. > > Please review the attached patch fixing this. > > > > Regards, > > Konstantin Triger > > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Mono-devel-list mailing list > > Mono-devel-list at lists.ximian.com > > http://lists.ximian.com/mailman/listinfo/mono-devel-list From atsushi at ximian.com Mon Mar 5 03:39:22 2007 From: atsushi at ximian.com (Atsushi Eno) Date: Mon, 05 Mar 2007 17:39:22 +0900 Subject: [Mono-dev] [PATCH] System.Web.Services: remove extra documentation item(s) from wsdl In-Reply-To: References: Message-ID: <45EBD73A.1060103@ximian.com> Hi Kosta, Konstantin Triger wrote: > Hi Eno, > > That's right, in Sys.Web.Services exists only "wsdl:documentation" case. But since you make a change in the generator code, the fix should be generic. > > What I mean is that if someone outside the Sys.Web.Services will create such a code and pass something different to "wsdl:documentation", he will get results different than on .net. Hmm I still don't get it - do you think that our SerializationCodeGenerator is now hardcoded to detect "documentation" in wsdl namespace? If not, what is the "generic" case that is in trouble? (That's kind of why I asked concrete trouble case ...) Atsushi Eno From kostat at mainsoft.com Mon Mar 5 04:29:08 2007 From: kostat at mainsoft.com (Konstantin Triger) Date: Mon, 5 Mar 2007 01:29:08 -0800 Subject: [Mono-dev] [PATCH] System.Web.Services: remove extra documentation item(s) from wsdl In-Reply-To: <45EBD73A.1060103@ximian.com> Message-ID: Hi Eno, Suppose someone has a class with the following property defined: [XmlAnyElement (Name="Some name", Namespace="some namesapce")] public XmlElement DocumentationElement { get { return docElement; } set { docElement = value; } } The SerializationCodeGenerator will produce something like this: if (o119 is XmlElement) { if ((o119.LocalName == "name from the XmlAnyElement attribute" && o119.NamespaceURI == "NS from the XmlAnyElement attribute")) { } else o119.WriteTo (Writer); WriteElementLiteral (o119, "", "", false, true); } else throw CreateUnknownAnyElementException (o119.Name, o119.NamespaceURI); So, currently, any element will be serialized, sometimes twice. The .Net creates different code, something like this: if ((o119.LocalName == "name from the XmlAnyElement attribute" && o119.NamespaceURI == "NS from the XmlAnyElement attribute")) WriteElementLiteral (o119, "", "", false, true); else throw CreateUnknownAnyElementException (o119.Name, o119.NamespaceURI); Regards, Konstantin Triger > -----Original Message----- > From: Atsushi Eno [mailto:atsushi at ximian.com] > Sent: Monday, March 05, 2007 10:39 AM > To: Konstantin Triger > Cc: Mono Development List > Subject: Re: [Mono-dev] [PATCH] System.Web.Services: remove extra > documentation item(s) from wsdl > > Hi Kosta, > > Konstantin Triger wrote: > > Hi Eno, > > > > That's right, in Sys.Web.Services exists only "wsdl:documentation" case. > But since you make a change in the generator code, the fix should be > generic. > > > > What I mean is that if someone outside the Sys.Web.Services will create > such a code and pass something different to "wsdl:documentation", he will > get results different than on .net. > > Hmm I still don't get it - do you think that our > SerializationCodeGenerator is now hardcoded to detect "documentation" > in wsdl namespace? If not, what is the "generic" case that is in > trouble? (That's kind of why I asked concrete trouble case ...) > > Atsushi Eno From manfred.braun at manfbraun.de Sun Mar 4 13:14:55 2007 From: manfred.braun at manfbraun.de (manfred.braun) Date: Sun, 4 Mar 2007 19:14:55 +0100 Subject: [Mono-dev] mono-xsp problem:page(s) does not participate in application (global.asax) Message-ID: Hi All! I try to use xsp on debian. In my global.asax, I declare a public property and try to access it on a web-page, like I do it with windows: <% = Global.conf %> Mono Runtime Version: 1.1.4322.2032 Error message: /tmp/www-data-temp-aspnet-0/fb9f12c0/13654cd5.0.cs(64,29) : error CS0103: The name `Global' does not exist in the context of `ASP.test_aspx' My global.asax starts like this: public class Global:System.Web.HttpApplication { .... As I said, I use it under windows the whole time. My Global class usually provides properties and methods which are used everywhere inside the whole application, means:in most pages. What Do I wrong?? Any help would be great! Thanks so far and best regards, Manfred From lorenzo.delana at gmail.com Mon Mar 5 01:31:54 2007 From: lorenzo.delana at gmail.com (lorenzo) Date: Mon, 5 Mar 2007 07:31:54 +0100 Subject: [Mono-dev] File.Copy on unix with symbolic link Message-ID: <200703050731.54896.fuzzybit@gmail.com> I'm developing a backup utility and this involves the use of File.Copy static method to make a copy of a file to another file. On Windows: a link to another file or directory ( the .lnk extension file ) is copied as is to destination. On Linux: a link to another file or directory ( the symlink ) is dereferenced and the destination result in the dereferenced file or directory. Why is used this implementation of the File.Copy w/symlink on Unix? The application work very different if I execute the same IL code on different platform. Is necessary to mantain this different behavior? Is there another solution to make a symlink copied as a symlink without using Mono.Unix libraries? thanks, lorenzo. From grendello at gmail.com Mon Mar 5 04:43:07 2007 From: grendello at gmail.com (Marek Habersack) Date: Mon, 5 Mar 2007 10:43:07 +0100 Subject: [Mono-dev] mono-xsp problem:page(s) does not participate in application (global.asax) In-Reply-To: References: Message-ID: <20070305104307.2e748b56@beowulf.thanes.org> On Sun, 4 Mar 2007 19:14:55 +0100, "manfred.braun" scribbled: > Hi All! Hey Manfred, > I try to use xsp on debian. In my global.asax, I declare a public property > and try to access it on a web-page, like I do it with windows: > > <% = Global.conf %> > > Mono Runtime Version: 1.1.4322.2032 > Error message: > /tmp/www-data-temp-aspnet-0/fb9f12c0/13654cd5.0.cs(64,29) : error CS0103: > The name `Global' does not exist in the context of `ASP.test_aspx' > > My global.asax starts like this: > > public class Global:System.Web.HttpApplication > { > .... > > As I said, I use it under windows the whole time. My Global class usually > provides properties and methods which are used everywhere inside the whole > application, means:in most pages. > > What Do I wrong?? Please post a minimal test case, regards, marek -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/4d037239/attachment.bin From fuzzybit at gmail.com Mon Mar 5 05:03:18 2007 From: fuzzybit at gmail.com (fuzzy bit) Date: Mon, 5 Mar 2007 11:03:18 +0100 Subject: [Mono-dev] File.Copy Modify/Access time file attribute Message-ID: When I use File.Copy the destination file: on Windows - file modify/access time is the same of the source file on Unix: - file modify/access time is the creation time of action copy A question: someone can help my to understand what say the ecma standard on System.IO.File.Copy behavior? I found only this description for System.IO.File.Copy: Description This method is equivalent to System.IO.File.Copy (sourceFileName, destFileName, false). The sourceFileName and destFileName arguments are permitted to specify relative or absolute path information. Relative path information is interpreted as relative to the current working directory. [Note: To obtain the current working directory, see System.IO.Directory.GetCurrentDirectory.] bye, lorenzo -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/d0ac4652/attachment.html From dick at ximian.com Mon Mar 5 05:27:19 2007 From: dick at ximian.com (Dick Porter) Date: Mon, 05 Mar 2007 10:27:19 +0000 Subject: [Mono-dev] File.Copy on unix with symbolic link In-Reply-To: <200703050731.54896.fuzzybit@gmail.com> References: <200703050731.54896.fuzzybit@gmail.com> Message-ID: <1173090439.4566.94.camel@hagbard.apathetic.discordia.org.uk> On Mon, 2007-03-05 at 07:31 +0100, lorenzo wrote: > I'm developing a backup utility and this involves the use of File.Copy static > method to make a copy of a file to another file. > > On Windows: > a link to another file or directory ( the .lnk extension file ) is copied as > is to destination. > > On Linux: > a link to another file or directory ( the symlink ) is dereferenced and the > destination result in the dereferenced file or directory. > > Why is used this implementation of the File.Copy w/symlink on Unix? > The application work very different if I execute the same IL code on different > platform. Is necessary to mantain this different behavior? POSIX symlinks and windows lnk files are two completely different concepts. In fact, I believe the latest version of windows has support for symlinks too. See http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/symbolic_link_effects_on_file_systems_functions.asp (I don't think we completely match the behaviour of the MS runtime wrt symlinks, and fixing it would require figuring out how they map the .net calls to the windows system calls.) > > Is there another solution to make a symlink copied as a symlink without using > Mono.Unix libraries? Not at the moment. - Dick -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/77173708/attachment.bin From atsushi at ximian.com Mon Mar 5 06:26:20 2007 From: atsushi at ximian.com (Atsushi Eno) Date: Mon, 05 Mar 2007 20:26:20 +0900 Subject: [Mono-dev] HttpListenerRequest.HasEntityBody Message-ID: <45EBFE5C.1060003@ximian.com> (This is a translated feedback from local users) Hi, It looks like our HttpListenerRequest.HasEntityBody is implemented not according to RFC2616 section 4. http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4 >From the source http://svn.myrealbox.com/source/trunk/mcs/class/System/System.Net/HttpListenerRequest.cs it is implemented as public bool HasEntityBody { get { return (method == "GET" || method == "HEAD" || content_length <= 0 || is_chunked); } } ... but the specification says nothing about the request method. So, wouldn't it be conceptually like this? if (Content-Length <= 0 && Transfer-Encoding == null && Content-Type != "multipart/byteranges") return false; return true; Atsushi Eno From sebastien.pouliot at gmail.com Mon Mar 5 08:15:00 2007 From: sebastien.pouliot at gmail.com (Sebastien Pouliot) Date: Mon, 05 Mar 2007 08:15:00 -0500 Subject: [Mono-dev] Math.cs patch correction In-Reply-To: <568148.78516.qm@web39605.mail.mud.yahoo.com> References: <568148.78516.qm@web39605.mail.mud.yahoo.com> Message-ID: <1173100501.3839.11.camel@poupou.home> Hello Dennis, Considering the first patch wasn't totally correct (in one case) it's clear that the existing unit tests are complete enough. So please check them and complete them to ensure all cases (including an invalid enum value) are tested. Thanks! On Sun, 2007-03-04 at 19:45 -0800, Dennis Hayes wrote: > This again cleans up the 2.0 rounding methods that use the > MidpointRounding enum options. > > It will give a small speed increase by moving a test that should never > fail from the top of the method to the bottom of the method, where is > should never need to be executed. > > My next task is to implment the missing methods. > Do I need to do anything more or different? > Dennis > > > > > ______________________________________________________________________ > Finding fabulous fares is fun. > Let Yahoo! FareChase search your favorite travel sites to find flight > and hotel bargains. > plain text document attachment (math.diff), "pat780224508" > Index: Math.cs > =================================================================== > --- Math.cs (revision 73696) > +++ Math.cs (working copy) > @@ -1,4 +1,4 @@ > -// > +?// > // System.Math.cs > // > // Authors: > @@ -373,23 +373,23 @@ > [MonoTODO ("Not implemented")] > public static decimal Round (decimal d, MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (d); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.AwayFromZero) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > [MonoTODO ("Not implemented")] > public static decimal Round (decimal d, int decimals, MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (d, decimals); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.AwayFromZero) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > #endif > > @@ -411,26 +411,26 @@ > #if NET_2_0 > public static double Round (double value, MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (value); > - if (value > 0) > - return Floor (value + 0.5); > - else > - return Ceiling (value - 0.5); > + if (mode == MidpointRounding.AwayFromZero){ > + if (value > 0) > + return Floor (value + 0.5); > + else > + return Ceiling (value - 0.5); > + } > + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > [MonoTODO ("Not implemented")] > public static double Round (double value, int digits, MidpointRounding mode) > { > - if ((mode != MidpointRounding.ToEven) && (mode != MidpointRounding.AwayFromZero)) > - throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > - > if (mode == MidpointRounding.ToEven) > return Round (value, digits); > - throw new NotImplementedException (); > + if (mode == MidpointRounding.AwayFromZero) > + throw new NotImplementedException (); > + > + throw new ArgumentException ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.", "mode"); > } > > public static double Truncate (double d) > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list -- Sebastien Pouliot Blog: http://pages.infinit.net/ctech/ From dave at fallingcanbedeadly.com Mon Mar 5 09:42:25 2007 From: dave at fallingcanbedeadly.com (David Mitchell) Date: Mon, 5 Mar 2007 06:42:25 -0800 Subject: [Mono-dev] Bugzilla bugs needing attention Message-ID: <008001c75f34$7e5ed230$1101a8c0@markii> I would like to direct your attention to the following Bugzilla bugs that require attention from someone. Patches exist to fix all of these, but I do not have write access to SVN, so I cannot apply them, myself. http://bugzilla.ximian.com/show_bug.cgi?id=80260 http://bugzilla.ximian.com/show_bug.cgi?id=80928 http://bugzilla.ximian.com/show_bug.cgi?id=80929 http://bugzilla.ximian.com/show_bug.cgi?id=80904 http://bugzilla.ximian.com/show_bug.cgi?id=80930 http://bugzilla.ximian.com/show_bug.cgi?id=81025 The first bug in this list is over a month old, and no one has even so much as added a comment to the bug since I attached the patch. Is there anything that can be done to speed up this process a bit? I understand the need for quality control and whatnot, but I fear that a number of people who are new to the project may become discouraged if they submit patches like this and then do not receive a response. --Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/ccd6d8f5/attachment.html From kostat at mainsoft.com Mon Mar 5 11:39:53 2007 From: kostat at mainsoft.com (Konstantin Triger) Date: Mon, 5 Mar 2007 08:39:53 -0800 Subject: [Mono-dev] [Mono-Dev] [PATCH] System.Web.Services, BasicProfile-1.1, R2401 Message-ID: Hello all, According to BasicProfile-1.1, R2401: A wsdl:binding element in a DESCRIPTION MUST use WSDL SOAP Binding as defined in WSDL 1.1 Section 3: 3. SOAP Binding WSDL includes a binding for SOAP 1.1 endpoints, which supports the specification of the following protocol specific information: * An indication that a binding is bound to the SOAP 1.1 protocol * A way of specifying an address for a SOAP endpoint. * The URI for the SOAPAction HTTP header for the HTTP binding of SOAP * A list of definitions for Headers that are transmitted as part of the SOAP Envelope This binding grammar it is not an exhaustive specification since the set of SOAP bindings is evolving. Nothing precludes additional SOAP bindings to be derived from portions of this grammar. For example: * SOAP bindings that do not employ a URI addressing scheme may substitute another addressing scheme by replacing the soap:address element defined in section 3.8. * SOAP bindings that do not require a SOAPAction omit the soapAction attribute defined in section 3.4. --------------------------- To my understanding, this means that to violate R2401 no SoapBinding should exist. The attached patch fixes this (and aligns with MS behavior). There is also another question: do we need to check the 1.1 conformance for SOAP 1.2? But this is a subject for another patch. Please review. Regards, Konstantin Triger -------------- next part -------------- A non-text attachment was scrubbed... Name: R2401.patch Type: application/octet-stream Size: 5647 bytes Desc: R2401.patch Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/3d4b907d/attachment.obj From monoman at gmail.com Mon Mar 5 14:03:58 2007 From: monoman at gmail.com (Rafael Teixeira) Date: Mon, 5 Mar 2007 16:03:58 -0300 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: <008001c75f34$7e5ed230$1101a8c0@markii> References: <008001c75f34$7e5ed230$1101a8c0@markii> Message-ID: Hi David, The number of code reviewers/commiters in Mono are less than we surely need and also those few have other tasks to accomplish, so we hope you, and others, can be a little patient, and sometimes also, without becoming rude, insist a bit, like you are doing. I've just glanced over the issues on bugzilla. The compiler one is probably best to leave to Miguel or Martin to commit. The others I'll verify the patches content and commit if no one objects in the next few hours. That if my networking troubles with access to Mono's SVN repository, doesn't forbid me. In that case I'll report in this thread. Thanks for your contributions, :) On 3/5/07, David Mitchell wrote: > > > > > I would like to direct your attention to the following Bugzilla bugs that > require attention from someone. Patches exist to fix all of these, but I do > not have write access to SVN, so I cannot apply them, myself. > > > > http://bugzilla.ximian.com/show_bug.cgi?id=80260 > > http://bugzilla.ximian.com/show_bug.cgi?id=80928 > > http://bugzilla.ximian.com/show_bug.cgi?id=80929 > > http://bugzilla.ximian.com/show_bug.cgi?id=80904 > > http://bugzilla.ximian.com/show_bug.cgi?id=80930 > > http://bugzilla.ximian.com/show_bug.cgi?id=81025 > > > > The first bug in this list is over a month old, and no one has even so much > as added a comment to the bug since I attached the patch. Is there anything > that can be done to speed up this process a bit? I understand the need for > quality control and whatnot, but I fear that a number of people who are new > to the project may become discouraged if they submit patches like this and > then do not receive a response. > > > > --Dave > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > -- Rafael "Monoman" Teixeira --------------------------------------- "The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man." George Bernard Shaw From calberto.cortez at gmail.com Mon Mar 5 12:24:03 2007 From: calberto.cortez at gmail.com (Carlos Alberto Cortez) Date: Mon, 05 Mar 2007 11:24:03 -0600 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: References: <008001c75f34$7e5ed230$1101a8c0@markii> Message-ID: <1173115443.2623.2.camel@localhost.localdomain> > The others I'll verify the patches content and commit if no > one objects in the next few hours. That if my networking troubles with > access to Mono's SVN repository, doesn't forbid me. In that case I'll > report in this thread. It would be a good idea to also have some tests for those patches before committing. Carlos. From miguel at novell.com Mon Mar 5 16:29:36 2007 From: miguel at novell.com (Miguel de Icaza) Date: Mon, 05 Mar 2007 16:29:36 -0500 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: <1173115443.2623.2.camel@localhost.localdomain> References: <008001c75f34$7e5ed230$1101a8c0@markii> <1173115443.2623.2.camel@localhost.localdomain> Message-ID: <1173130176.6580.21.camel@erandi.dom> Hello, > > The others I'll verify the patches content and commit if no > > one objects in the next few hours. That if my networking troubles with > > access to Mono's SVN repository, doesn't forbid me. In that case I'll > > report in this thread. > > It would be a good idea to also have some tests for those patches before > committing. I read the patches, most of them do not need a test, and those that need have it. From monoman at gmail.com Mon Mar 5 16:35:10 2007 From: monoman at gmail.com (Rafael Teixeira) Date: Mon, 5 Mar 2007 18:35:10 -0300 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: <1173130176.6580.21.camel@erandi.dom> References: <008001c75f34$7e5ed230$1101a8c0@markii> <1173115443.2623.2.camel@localhost.localdomain> <1173130176.6580.21.camel@erandi.dom> Message-ID: Miguel, I continue to have problems like this: >$ svn up ssh: mono-cvs.ximian.com: Temporary failure in name resolution svn: Connection closed unexpectedly >$ ping mono-cvs.ximian.com PING mono-cvs.ximian.com (130.57.169.27) 56(84) bytes of data. --- mono-cvs.ximian.com ping statistics --- 4 packets transmitted, 0 received, 100% packet loss, time 2999ms Can you please commit those patches? Thanks, On 3/5/07, Miguel de Icaza wrote: > Hello, > > > > The others I'll verify the patches content and commit if no > > > one objects in the next few hours. That if my networking troubles with > > > access to Mono's SVN repository, doesn't forbid me. In that case I'll > > > report in this thread. > > > > It would be a good idea to also have some tests for those patches before > > committing. > > I read the patches, most of them do not need a test, and those that need > have it. > -- Rafael "Monoman" Teixeira --------------------------------------- "The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man." George Bernard Shaw From everaldo at simios.org Mon Mar 5 17:11:07 2007 From: everaldo at simios.org (Everaldo Canuto) Date: Mon, 5 Mar 2007 19:11:07 -0300 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: References: <008001c75f34$7e5ed230$1101a8c0@markii> <1173115443.2623.2.camel@localhost.localdomain> <1173130176.6580.21.camel@erandi.dom> Message-ID: <53b944780703051411w56aa23e3w529c4595bdb6b2ef@mail.gmail.com> Hey Rafael, For strange reasons some provider in Sao Paulo theres DNS problems, here I solve this using IG dns server, it also speed up some name resolution. put "nameserver 200.225.157.104" at first line of your /etc/resolv.conf Everaldo On 3/5/07, Rafael Teixeira wrote: > Miguel, I continue to have problems like this: > > >$ svn up > ssh: mono-cvs.ximian.com: Temporary failure in name resolution > svn: Connection closed unexpectedly > >$ ping mono-cvs.ximian.com > PING mono-cvs.ximian.com (130.57.169.27) 56(84) bytes of data. > > --- mono-cvs.ximian.com ping statistics --- > 4 packets transmitted, 0 received, 100% packet loss, time 2999ms > > > Can you please commit those patches? > > Thanks, > > On 3/5/07, Miguel de Icaza wrote: > > Hello, > > > > > > The others I'll verify the patches content and commit if no > > > > one objects in the next few hours. That if my networking troubles with > > > > access to Mono's SVN repository, doesn't forbid me. In that case I'll > > > > report in this thread. > > > > > > It would be a good idea to also have some tests for those patches before > > > committing. > > > > I read the patches, most of them do not need a test, and those that need > > have it. > > > > > -- > Rafael "Monoman" Teixeira > --------------------------------------- > "The reasonable man adapts himself to the world; the unreasonable one > persists in trying to adapt the world to himself. Therefore all > progress depends on the unreasonable man." George Bernard Shaw > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > From miguel at novell.com Mon Mar 5 17:13:51 2007 From: miguel at novell.com (Miguel de Icaza) Date: Mon, 05 Mar 2007 17:13:51 -0500 Subject: [Mono-dev] Bugzilla bugs needing attention In-Reply-To: <008001c75f34$7e5ed230$1101a8c0@markii> References: <008001c75f34$7e5ed230$1101a8c0@markii> Message-ID: <1173132831.6580.30.camel@erandi.dom> Hello David, > I would like to direct your attention to the following Bugzilla bugs > that require attention from someone. Patches exist to fix all of > these, but I do not have write access to SVN, so I cannot apply them, > myself. Am sorry that we did not get to those bugs before, the bug fixes were great, and you also provided tests for them, that was absolutely fantastic. I cooked only one test for the generics change in MCS. Thanks a million for them. Btw, am hiring a QA person to make sure that these kind of problems do not happen in the future. If anyone is interested, let me know. Miguel > From miguel at ximian.com Mon Mar 5 23:50:07 2007 From: miguel at ximian.com (Miguel de Icaza) Date: Mon, 05 Mar 2007 23:50:07 -0500 Subject: [Mono-dev] Regression in String tests Message-ID: <1173156607.22991.8.camel@erandi.dom> I just noticed this while running the corlib tests: Failures: 1) MonoTests.System.StringTest.StringProperties : String lengths differ. Expected length=6, but was length=5. Strings differ at index 0. expected:<"Length"> but was:<"Chars"> -----------^ at MonoTests.System.StringTest.StringProperties () [0x00010] in /home/cvs/mcs/class/corlib/Test/System/StringTest.cs:1807 at <0x00000> at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[]) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00040] in /home/cvs/mcs/class/corlib/System.Reflection/MonoMethod.cs:143 From dave at fallingcanbedeadly.com Tue Mar 6 00:31:41 2007 From: dave at fallingcanbedeadly.com (David Mitchell) Date: Mon, 5 Mar 2007 21:31:41 -0800 Subject: [Mono-dev] Generic type naming Message-ID: <00a501c75fb0$b87e8290$1101a8c0@markii> My apologies if I am dredging up an issue that has already been resolved and put to rest, but my curiosity compels me to do so. I have noticed that Mono's algorithms for providing names to specific generic types is significantly different to that of Microsoft's implementation of .Net. Where Microsoft's implementation usually has lots of fancy angle brackets and full type listings of the arguments, Mono often has weird accent marks and numbers. Is this difference between the two implementations the result of an architectural decision, developer laziness (hey, the best developers are all a bit lazy, right?), or of something in between the two extremes? Thanks, --Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070305/9d703d28/attachment.html From atsushi at ximian.com Tue Mar 6 01:50:51 2007 From: atsushi at ximian.com (Atsushi Eno) Date: Tue, 06 Mar 2007 15:50:51 +0900 Subject: [Mono-dev] Regression in String tests In-Reply-To: <1173156607.22991.8.camel@erandi.dom> References: <1173156607.22991.8.camel@erandi.dom> Message-ID: <45ED0F4B.8000601@ximian.com> It is not a regression. Actually the test is quite odd. [Test] public void StringProperties() { PropertyInfo[] props = typeof(String).GetProperties(); AssertEquals(props[0].Name, "Chars"); AssertEquals(props[1].Name, "Length"); } I'll revert r73699. Atsushi Eno Miguel de Icaza wrote: > I just noticed this while running the corlib tests: > > Failures: > 1) MonoTests.System.StringTest.StringProperties : > String lengths differ. Expected length=6, but was length=5. > Strings differ at index 0. > > expected:<"Length"> > but was:<"Chars"> > -----------^ > > at MonoTests.System.StringTest.StringProperties () [0x00010] > in /home/cvs/mcs/class/corlib/Test/System/StringTest.cs:1807 > at <0x00000> > at (wrapper managed-to-native) > System.Reflection.MonoMethod:InternalInvoke (object,object[]) > at System.Reflection.MonoMethod.Invoke (System.Object obj, > BindingFlags invokeAttr, System.Reflection.Binder binder, > System.Object[] parameters, System.Globalization.CultureInfo culture) > [0x00040] > in /home/cvs/mcs/class/corlib/System.Reflection/MonoMethod.cs:143 > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > From robertj at gmx.net Tue Mar 6 02:26:13 2007 From: robertj at gmx.net (Robert Jordan) Date: Tue, 06 Mar 2007 08:26:13 +0100 Subject: [Mono-dev] Generic type naming In-Reply-To: <00a501c75fb0$b87e8290$1101a8c0@markii> References: <00a501c75fb0$b87e8290$1101a8c0@markii> Message-ID: David Mitchell wrote: > My apologies if I am dredging up an issue that has already been resolved and > put to rest, but my curiosity compels me to do so. > > > > I have noticed that Mono's algorithms for providing names to specific > generic types is significantly different to that of Microsoft's > implementation of .Net. Where Microsoft's implementation usually has lots of > fancy angle brackets and full type listings of the arguments, Mono often has > weird accent marks and numbers. Like Mono, MS uses the accent marks as well. For example, Dictionary`2[K, T] denotes the non-instantiated generic type Dictionary (C# notation), whereas Dictionary`2[[String, Int32]] is an instantiated Dictionary (C# notation). When full names are requested, the type names become ever weirder: System.Collections.Generic.Dictionary`2 [ [ System.String, mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 ], [ System.Int32, mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 ] ] > Is this difference between the two implementations the result of an > architectural decision, developer laziness (hey, the best developers are all > a bit lazy, right?), or of something in between the two extremes? There should be no differences. Please file bugs if you find some. Robert From jamie.cansdale at testdriven.net Tue Mar 6 03:03:58 2007 From: jamie.cansdale at testdriven.net (Jamie Cansdale) Date: Tue, 6 Mar 2007 08:03:58 +0000 Subject: [Mono-dev] Regression in String tests In-Reply-To: <45ED0F4B.8000601@ximian.com> References: <1173156607.22991.8.camel@erandi.dom> <45ED0F4B.8000601@ximian.com> Message-ID: <583d4c740703060003x1ee56232o8b2197c50522e03f@mail.gmail.com> > PropertyInfo[] props = typeof(String).GetProperties(); > AssertEquals(props[0].Name, "Chars"); > AssertEquals(props[1].Name, "Length"); I'm curious it know what this is testing for. I thought the ordering of reflected members was explicitly not guaranteed. IIRC there was talk of returning them in random order in .NET 2.0 to discourage this kind of dependency. Thanks, Jamie. -- http://www.testdriven.net http://weblogs.asp.net/nunitaddin On 3/6/07, Atsushi Eno wrote: > It is not a regression. Actually the test is quite odd. > > [Test] > public void StringProperties() > { > PropertyInfo[] props = typeof(String).GetProperties(); > AssertEquals(props[0].Name, "Chars"); > AssertEquals(props[1].Name, "Length"); > } > > I'll revert r73699. > > Atsushi Eno > > Miguel de Icaza wrote: > > I just noticed this while running the corlib tests: > > > > Failures: > > 1) MonoTests.System.StringTest.StringProperties : > > String lengths differ. Expected length=6, but was length=5. > > Strings differ at index 0. > > > > expected:<"Length"> > > but was:<"Chars"> > > -----------^ > > > > at MonoTests.System.StringTest.StringProperties () [0x00010] > > in /home/cvs/mcs/class/corlib/Test/System/StringTest.cs:1807 > > at <0x00000> > > at (wrapper managed-to-native) > > System.Reflection.MonoMethod:InternalInvoke (object,object[]) > > at System.Reflection.MonoMethod.Invoke (System.Object obj, > > BindingFlags invokeAttr, System.Reflection.Binder binder, > > System.Object[] parameters, System.Globalization.CultureInfo culture) > > [0x00040] > > in /home/cvs/mcs/class/corlib/System.Reflection/MonoMethod.cs:143 > > > > > > _______________________________________________ > > Mono-devel-list mailing list > > Mono-devel-list at lists.ximian.com > > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > From roeie at mainsoft.com Tue Mar 6 03:07:45 2007 From: roeie at mainsoft.com (Roei Erez) Date: Tue, 6 Mar 2007 00:07:45 -0800 Subject: [Mono-dev] Regression in String tests In-Reply-To: <583d4c740703060003x1ee56232o8b2197c50522e03f@mail.gmail.com> Message-ID: Yes, I you are right, I will fix the test. -----Original Message----- From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Jamie Cansdale Sent: Tuesday, March 06, 2007 10:04 AM To: mono-devel-list at lists.ximian.com Subject: Re: [Mono-dev] Regression in String tests > PropertyInfo[] props = typeof(String).GetProperties(); > AssertEquals(props[0].Name, "Chars"); > AssertEquals(props[1].Name, "Length"); I'm curious it know what this is testing for. I thought the ordering of reflected members was explicitly not guaranteed. IIRC there was talk of returning them in random order in .NET 2.0 to discourage this kind of dependency. Thanks, Jamie. -- http://www.testdriven.net http://weblogs.asp.net/nunitaddin On 3/6/07, Atsushi Eno wrote: > It is not a regression. Actually the test is quite odd. > > [Test] > public void StringProperties() > { > PropertyInfo[] props = typeof(String).GetProperties(); > AssertEquals(props[0].Name, "Chars"); > AssertEquals(props[1].Name, "Length"); > } > > I'll revert r73699. > > Atsushi Eno > > Miguel de Icaza wrote: > > I just noticed this while running the corlib tests: > > > > Failures: > > 1) MonoTests.System.StringTest.StringProperties : > > String lengths differ. Expected length=6, but was length=5. > > Strings differ at index 0. > > > > expected:<"Length"> > > but was:<"Chars"> > > -----------^ > > > > at MonoTests.System.StringTest.StringProperties () [0x00010] in > > /home/cvs/mcs/class/corlib/Test/System/StringTest.cs:1807 > > at <0x00000> > > at (wrapper managed-to-native) > > System.Reflection.MonoMethod:InternalInvoke (object,object[]) > > at System.Reflection.MonoMethod.Invoke (System.Object obj, > > BindingFlags invokeAttr, System.Reflection.Binder binder, > > System.Object[] parameters, System.Globalization.CultureInfo > > culture) [0x00040] in > > /home/cvs/mcs/class/corlib/System.Reflection/MonoMethod.cs:143 > > > > > > _______________________________________________ > > Mono-devel-list mailing list > > Mono-devel-list at lists.ximian.com > > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > _______________________________________________ Mono-devel-list mailing list Mono-devel-list at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list From igorz at mainsoft.com Tue Mar 6 04:24:18 2007 From: igorz at mainsoft.com (Igor Zelmanovich) Date: Tue, 6 Mar 2007 01:24:18 -0800 Subject: [Mono-dev] [Patch] System.Web.UI.WebControls.DataGrid Message-ID: Attached is patch fixes DataGrid.AutoGenerateColumns feature: Auto-generated columns are restored properly on postback from view state. Please preview. Regards, Igor Zelmanovich. igorz at mainsoft.com -------------- next part -------------- A non-text attachment was scrubbed... Name: DataGrid.patch Type: application/octet-stream Size: 1642 bytes Desc: DataGrid.patch Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070306/e2b40a05/attachment.obj From igorz at mainsoft.com Tue Mar 6 08:57:41 2007 From: igorz at mainsoft.com (Igor Zelmanovich) Date: Tue, 6 Mar 2007 05:57:41 -0800 Subject: [Mono-dev] [Mono-patches] r73707 - in trunk/mcs/class/System.Web:System.Web.Compilation System.Web.Util In-Reply-To: <20070305135816.C74DC9472C@mono-cvs.ximian.com> References: <20070305135816.C74DC9472C@mono-cvs.ximian.com> Message-ID: This patch causes 7 regressions in tests (System.Web.UI.WebControls.ThemeTest.cs). Please fix or revert. Igor. -----Original Message----- From: mono-patches-bounces at lists.ximian.com [mailto:mono-patches-bounces at lists.ximian.com] On Behalf Of Marek Habersack (grendello at gmail.com) Sent: Monday, March 05, 2007 3:58 PM To: mono-patches at lists.ximian.com; ximian.monolist at gmail.com; mono-svn-patches-garchive-20758 at googlegroups.com Subject: [Mono-patches] r73707 - in trunk/mcs/class/System.Web:System.Web.Compilation System.Web.Util Author: mhabersack Date: 2007-03-05 08:58:16 -0500 (Mon, 05 Mar 2007) New Revision: 73707 Modified: trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog trunk/mcs/class/System.Web/System.Web.Compilation/PageThemeCompiler.cs trunk/mcs/class/System.Web/System.Web.Compilation/ThemeDirectoryCompiler .cs trunk/mcs/class/System.Web/System.Web.Util/ChangeLog trunk/mcs/class/System.Web/System.Web.Util/UrlUtils.cs Log: make themes work. Also fixes bug #80953 Modified: trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog =================================================================== --- trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog 2007-03-05 12:58:16 UTC (rev 73706) +++ trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog 2007-03-05 13:58:16 UTC (rev 73707) @@ -1,3 +1,13 @@ +2007-03-05 Marek Habersack + + * PageThemeCompiler.cs: Use correct theme path for + AppRelativeTemplateSourceDirectory. + Do not process builders of type CodeRenderBuilder. + Make sure builder.ControlType is not null before depending on it. + + * ThemeDirectoryCompiler.cs: theme parser should be passed the + virtual directory of the theme. + 2007-03-03 Marek Habersack * PageCompiler.cs: Added support for setting the Modified: trunk/mcs/class/System.Web/System.Web.Compilation/PageThemeCompiler.cs =================================================================== --- trunk/mcs/class/System.Web/System.Web.Compilation/PageThemeCompiler.cs 2007-03-05 12:58:16 UTC (rev 73706) +++ trunk/mcs/class/System.Web/System.Web.Compilation/PageThemeCompiler.cs 2007-03-05 13:58:16 UTC (rev 73707) @@ -94,7 +94,9 @@ prop.Name = "AppRelativeTemplateSourceDirectory"; prop.Attributes = MemberAttributes.Family | MemberAttributes.Override; prop.Type = new CodeTypeReference (typeof (string)); - prop.GetStatements.Add (new CodeMethodReturnStatement (new CodePrimitiveExpression (parser.BaseVirtualDir))); + prop.GetStatements.Add (new CodeMethodReturnStatement ( + new CodePrimitiveExpression ( + VirtualPathUtility.ToAbsolute (parser.BaseVirtualDir)))); mainClass.Members.Add (prop); ControlBuilder builder = parser.RootBuilder; @@ -102,7 +104,9 @@ foreach (object o in builder.Children) { if (! (o is ControlBuilder)) continue; - + if (o is CodeRenderBuilder) + continue; + ControlBuilder b = (ControlBuilder) o; CreateControlSkinMethod (b); } @@ -133,6 +137,9 @@ void CreateControlSkinMethod (ControlBuilder builder) { + if (builder.ControlType == null) + return; + EnsureID (builder); CodeMemberMethod method = new CodeMemberMethod (); @@ -164,6 +171,9 @@ continue; ControlBuilder b = (ControlBuilder) o; + if (b.isProperty) + continue; + if (b is CollectionBuilder) { PropertyInfo itemsProp = null; @@ -203,25 +213,29 @@ foreach (object o in builder.Children) { if (o is string) /* literal stuff gets ignored */ continue; - + if (o is CodeRenderBuilder) + continue; ControlBuilder b = (ControlBuilder) o; EnsureID (b); - + Type controlType = b.ControlType; + if (controlType == null) + continue; + string id = b.ID; - string skinId = b.attribs["skinid"] as string; - Type controlType = b.ControlType; + string skinId = b.attribs != null ? b.attribs["skinid"] as string : null; + if (skinId == null) + skinId = ""; - if (skinId == null) skinId = ""; - // private static object __BuildControl__$id_skinKey = System.Web.UI.PageTheme.CreateSkinKey(typeof($controlType), "$skinID") // CodeMemberField fld = new CodeMemberField (typeof (object), "__BuildControl_" + id + "_skinKey"); fld.Attributes = MemberAttributes.Private | MemberAttributes.Static; - fld.InitExpression = new CodeMethodInvokeExpression (new CodeTypeReferenceExpression (typeof (PageTheme)), - "CreateSkinKey", - new CodeTypeOfExpression (controlType), - new CodePrimitiveExpression (skinId)); + fld.InitExpression = new CodeMethodInvokeExpression ( + new CodeTypeReferenceExpression (typeof (PageTheme)), + "CreateSkinKey", + new CodeTypeOfExpression (controlType), + new CodePrimitiveExpression (skinId)); mainClass.Members.Add (fld); } @@ -229,7 +243,7 @@ } protected override void CreateConstructor (CodeStatementCollection localVars, - CodeStatementCollection trueStmt) + CodeStatementCollection trueStmt) { ControlBuilder builder = parser.RootBuilder; @@ -237,12 +251,16 @@ foreach (object o in builder.Children) { if (o is string) /* literal stuff gets ignored */ continue; - + if (o is CodeRenderBuilder) + continue; + ControlBuilder b = (ControlBuilder) o; + Type controlType = b.ControlType; + if (controlType == null) + continue; string id = b.ID; - Type controlType = b.ControlType; - + if (localVars == null) localVars = new CodeStatementCollection (); Modified: trunk/mcs/class/System.Web/System.Web.Compilation/ThemeDirectoryCompiler .cs =================================================================== --- trunk/mcs/class/System.Web/System.Web.Compilation/ThemeDirectoryCompiler .cs 2007-03-05 12:58:16 UTC (rev 73706) +++ trunk/mcs/class/System.Web/System.Web.Compilation/ThemeDirectoryCompiler .cs 2007-03-05 13:58:16 UTC (rev 73707) @@ -49,7 +49,7 @@ throw new HttpException (String.Format ("Theme '{0}' cannot be found in the application or global theme directories.", theme)); string [] skin_files = Directory.GetFiles (physicalPath, "*.skin"); - PageThemeParser ptp = new PageThemeParser (physicalPath, context); + PageThemeParser ptp = new PageThemeParser (virtualPath, context); string[] css_files = Directory.GetFiles (physicalPath, "*.css"); string[] css_urls = new string[css_files.Length]; Modified: trunk/mcs/class/System.Web/System.Web.Util/ChangeLog =================================================================== --- trunk/mcs/class/System.Web/System.Web.Util/ChangeLog 2007-03-05 12:58:16 UTC (rev 73706) +++ trunk/mcs/class/System.Web/System.Web.Util/ChangeLog 2007-03-05 13:58:16 UTC (rev 73707) @@ -1,3 +1,8 @@ +2007-03-05 Marek Habersack + + * UrlUtils.cs: Make sure GetDirectory returns a directory with the + trailing slash. + 2007-01-30 Adar Wesley * UrlUtils.cs: fixed GetFile to throw right exception Modified: trunk/mcs/class/System.Web/System.Web.Util/UrlUtils.cs =================================================================== --- trunk/mcs/class/System.Web/System.Web.Util/UrlUtils.cs 2007-03-05 12:58:16 UTC (rev 73706) +++ trunk/mcs/class/System.Web/System.Web.Util/UrlUtils.cs 2007-03-05 13:58:16 UTC (rev 73707) @@ -183,6 +183,8 @@ int last = url.LastIndexOf ('/'); if (last > 0) { + if (last + 1 == url.Length) + last++; #if NET_2_0 return RemoveDoubleSlashes (url.Substring (0, last)); #else _______________________________________________ Mono-patches maillist - Mono-patches at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-patches From grendello at gmail.com Tue Mar 6 09:03:45 2007 From: grendello at gmail.com (Marek Habersack) Date: Tue, 6 Mar 2007 15:03:45 +0100 Subject: [Mono-dev] [Mono-patches] r73707 - in trunk/mcs/class/System.Web:System.Web.Compilation System.Web.Util In-Reply-To: References: <20070305135816.C74DC9472C@mono-cvs.ximian.com> Message-ID: <20070306150345.0b76e9a4@beowulf.thanes.org> On Tue, 6 Mar 2007 05:57:41 -0800, "Igor Zelmanovich" scribbled: > This patch causes 7 regressions in tests > (System.Web.UI.WebControls.ThemeTest.cs). > > Please fix or revert. I'm aware of the regressions. Prior to this patch there were 15 of them. I'll fix the rest this week. regards, marek -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070306/6e159536/attachment.bin From igorz at mainsoft.com Tue Mar 6 09:41:29 2007 From: igorz at mainsoft.com (Igor Zelmanovich) Date: Tue, 6 Mar 2007 06:41:29 -0800 Subject: [Mono-dev] [Mono-patches] r73587 -trunk/mcs/class/System.Web/System.Web.Compilation In-Reply-To: <20070301135719.07BF99472C@mono-cvs.ximian.com> References: <20070301135719.07BF99472C@mono-cvs.ximian.com> Message-ID: This patch causes 3 regressions in tests (System.Web.UI.WebControls.XmlDataSource.cs). Please fix or revert. -----Original Message----- From: mono-patches-bounces at lists.ximian.com [mailto:mono-patches-bounces at lists.ximian.com] On Behalf Of Marek Habersack (grendello at gmail.com) Sent: Thursday, March 01, 2007 3:57 PM To: mono-patches at lists.ximian.com; ximian.monolist at gmail.com; mono-svn-patches-garchive-20758 at googlegroups.com Subject: [Mono-patches] r73587 -trunk/mcs/class/System.Web/System.Web.Compilation Author: mhabersack Date: 2007-03-01 08:57:18 -0500 (Thu, 01 Mar 2007) New Revision: 73587 Modified: trunk/mcs/class/System.Web/System.Web.Compilation/AspParser.cs trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog Log: Fix for the asp parser Modified: trunk/mcs/class/System.Web/System.Web.Compilation/AspParser.cs =================================================================== --- trunk/mcs/class/System.Web/System.Web.Compilation/AspParser.cs 2007-03-01 13:08:04 UTC (rev 73586) +++ trunk/mcs/class/System.Web/System.Web.Compilation/AspParser.cs 2007-03-01 13:57:18 UTC (rev 73587) @@ -362,39 +362,41 @@ } string GetVerbatim (int token, string end) - { - StringBuilder vb_text = new StringBuilder (); - int i = 0; + { + StringBuilder vb_text = new StringBuilder (); + int i = 0, i2 = 0; - if (tokenizer.Value.Length > 1){ - // May be we have a put_back token that is not a single character - vb_text.Append (tokenizer.Value); - token = tokenizer.get_token (); - } + if (tokenizer.Value.Length > 1){ + // May be we have a put_back token that is not a single character + vb_text.Append (tokenizer.Value); + token = tokenizer.get_token (); + } - end = end.ToLower (CultureInfo.InvariantCulture); - while (token != Token.EOF){ - if (Char.ToLower ((char) token, CultureInfo.InvariantCulture) == end [i]){ - if (++i >= end.Length) - break; - token = tokenizer.get_token (); - continue; - } else if (i > 0) { - for (int j = 0; j < i; j++) - vb_text.Append (end [j]); - i = 0; - } + end = end.ToLower (CultureInfo.InvariantCulture); + while (token != Token.EOF){ + if (Char.ToLower ((char) token, CultureInfo.InvariantCulture) == end [i]){ + i2++; + if (++i >= end.Length) + break; + token = tokenizer.get_token (); + continue; + } else if (i > 0) { + if (i > 1) + i2 -= i; + for (int j = 0; j < i2; j++) + vb_text.Append (end [j]); + i2 = 0; + } + vb_text.Append ((char) token); + token = tokenizer.get_token (); + } - vb_text.Append ((char) token); - token = tokenizer.get_token (); - } + if (token == Token.EOF) + OnError ("Expecting " + end + " and got EOF."); - if (token == Token.EOF) - OnError ("Expecting " + end + " and got EOF."); + return RemoveComments (vb_text.ToString ()); + } - return RemoveComments (vb_text.ToString ()); - } - string RemoveComments (string text) { int end; Modified: trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog =================================================================== --- trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog 2007-03-01 13:08:04 UTC (rev 73586) +++ trunk/mcs/class/System.Web/System.Web.Compilation/ChangeLog 2007-03-01 13:57:18 UTC (rev 73587) @@ -1,3 +1,10 @@ +2007-03-01 Marek Habersack + + * AspParser.cs: fix GetVerbatim for cases when the end is + e.g. --> or --%> and the string matched is ---> or ---%> + respectively. The new code always backs out to make sure the end is + matched correctly. + 2007-02-27 Marek Habersack * TemplateControlCompiler.cs: ParseExpression returns an object, _______________________________________________ Mono-patches maillist - Mono-patches at lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-patches From grendello at gmail.com Tue Mar 6 10:17:30 2007 From: grendello at gmail.com (Marek Habersack) Date: Tue, 6 Mar 2007 16:17:30 +0100 Subject: [Mono-dev] [Mono-patches] r73587 -trunk/mcs/class/System.Web/System.Web.Compilation In-Reply-To: References: <20070301135719.07BF99472C@mono-cvs.ximian.com> Message-ID: <20070306161730.2363ed8c@beowulf.thanes.org> On Tue, 6 Mar 2007 06:41:29 -0800, "Igor Zelmanovich" scribbled: > This patch causes 3 regressions in tests > (System.Web.UI.WebControls.XmlDataSource.cs). > > Please fix or revert. This patch fixes a bug in a parser, so it won't get reversed. I will examine the failing tests this week as well. regards, marek -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070306/10293be7/attachment.bin From grendello at gmail.com Tue Mar 6 20:41:50 2007 From: grendello at gmail.com (Marek Habersack) Date: Wed, 7 Mar 2007 02:41:50 +0100 Subject: [Mono-dev] [Mono-patches] r73587 -trunk/mcs/class/System.Web/System.Web.Compilation In-Reply-To: <20070306161730.2363ed8c@beowulf.thanes.org> References: <20070301135719.07BF99472C@mono-cvs.ximian.com> <20070306161730.2363ed8c@beowulf.thanes.org> Message-ID: <20070307024150.29cad6b0@beowulf.thanes.org> On Tue, 6 Mar 2007 16:17:30 +0100, Marek Habersack scribbled: > On Tue, 6 Mar 2007 06:41:29 -0800, "Igor Zelmanovich" > scribbled: > > > This patch causes 3 regressions in tests > > (System.Web.UI.WebControls.XmlDataSource.cs). > > > > Please fix or revert. > This patch fixes a bug in a parser, so it won't get reversed. I will examine > the failing tests this week as well. Igor, I've just realized that I've been unnecessarily harsh in my responses. It's due to the fact that I was in hurry and wrote the answers quickly and to the point - hope you didn't take that personally :) and I'm sorry if you did, best regards, marek -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070307/3952045a/attachment.bin From dave at fallingcanbedeadly.com Tue Mar 6 20:58:47 2007 From: dave at fallingcanbedeadly.com (David Mitchell) Date: Tue, 6 Mar 2007 17:58:47 -0800 Subject: [Mono-dev] (More) Bugzilla bugs with patches In-Reply-To: <008001c75f34$7e5ed230$1101a8c0@markii> References: <008001c75f34$7e5ed230$1101a8c0@markii> Message-ID: <00d801c7605c$25099070$1101a8c0@markii> So.I've been kind of busy, and consequently, I've made patches for the following three bugs: http://bugzilla.ximian.com/show_bug.cgi?id=81046 http://bugzilla.ximian.com/show_bug.cgi?id=81047 http://bugzilla.ximian.com/show_bug.cgi?id=81048 All three of these are very minor patches related to the kinds of exceptions that List can throw when it is accessed through the IList interface. I'd appreciate it if someone could review/apply them. --Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070306/21a87eed/attachment.html From dave at fallingcanbedeadly.com Wed Mar 7 01:36:32 2007 From: dave at fallingcanbedeadly.com (David Mitchell) Date: Tue, 6 Mar 2007 22:36:32 -0800 Subject: [Mono-dev] Regression of bug 80260? Message-ID: <00e301c76082$f24a9ea0$1101a8c0@markii> I just did a Subversion get and attempted to build a project that used to be affected by this bug: http://bugzilla.ximian.com/show_bug.cgi?id=80260 Yesterday, the patch to fix it was applied, and everything worked fine. However, after my most recent update, it is broken again. Does anyone know about why this may have changed? --Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070306/b8519ea9/attachment.html From miguel at novell.com Wed Mar 7 01:57:42 2007 From: miguel at novell.com (Miguel de Icaza) Date: Wed, 07 Mar 2007 01:57:42 -0500 Subject: [Mono-dev] Regression of bug 80260? In-Reply-To: <00e301c76082$f24a9ea0$1101a8c0@markii> References: <00e301c76082$f24a9ea0$1101a8c0@markii> Message-ID: <1173250662.20389.6.camel@erandi.dom> Hello, > I just did a Subversion get and attempted to build a project that used > to be affected by this bug: I backed out that patch temporarily, but it should be enabled again (maybe AnonSVN is still behind the main release?) > > > http://bugzilla.ximian.com/show_bug.cgi?id=80260 > > > > Yesterday, the patch to fix it was applied, and everything worked > fine. However, after my most recent update, it is broken again. > > > > Does anyone know about why this may have changed? > > > > --Dave > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list at lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list From miguel at novell.com Wed Mar 7 01:59:23 2007 From: miguel at novell.com (Miguel de Icaza) Date: Wed, 07 Mar 2007 01:59:23 -0500 Subject: [Mono-dev] Regression of bug 80260? In-Reply-To: <00e301c76082$f24a9ea0$1101a8c0@markii> References: <00e301c76082$f24a9ea0$1101a8c0@markii> Message-ID: <1173250763.20389.8.camel@erandi.dom> Hello, > I just did a Subversion get and attempted to build a project that used > to be affected by this bug: > > http://bugzilla.ximian.com/show_bug.cgi?id=80260 My mistake, I forgot to reapply it; I will do so tomorrow morning. > From =?ISO-8859-1?Q?=22Andr=E9s_G=2E_Aragoneses_=5B_knocte_=5D?= Wed Mar 7 10:56:41 2007 From: =?ISO-8859-1?Q?=22Andr=E9s_G=2E_Aragoneses_=5B_knocte_=5D?= (=?ISO-8859-1?Q?=22Andr=E9s_G=2E_Aragoneses_=5B_knocte_=5D?=) Date: Wed, 07 Mar 2007 16:56:41 +0100 Subject: [Mono-dev] Patch to add two notworking tests (System.Net) In-Reply-To: <117799f00702110653g465fa7c2o4a0b7e77e0a4aa2a@mail.gmail.com> References: <117799f00702110653g465fa7c2o4a0b7e77e0a4aa2a@mail.gmail.com> Message-ID: <45EEE0B9.3070206@gmail.com> Hi Alan, let me rescue this thread (I've been very busy until now): Alan McGovern escribi?: > Hi, > > Here's how i did it in my own tests. I test in an english culture first, > then german culture. > > System.Threading.Thread.CurrentThread.CurrentCulture = > CultureInfo.GetCultureInfo("en-IE"); > Assert.AreEqual("{X:-124 Y:352.234 Z:123.123}", c.ToString(), > "#1"); > > System.Threading.Thread.CurrentThread.CurrentCulture = > CultureInfo.GetCultureInfo("de-DE"); > Assert.AreEqual("{X:-124 Y:352,234 Z:123,123}", c.ToString(), > "#2"); > > Vector3 v = new Vector3(1324.2353252353223f, > 1324.2353252353223f, > 1324.2353252353223f); > Assert.AreEqual("{X:1324,235 Y:1324,235 Z:1324,235}", > v.ToString(), > "#3"); I'm trying your technique with my MS.NET installation and I don't manage to get it working (I keep getting exception messages in Spanish instead of English). For example the simple code of my testcase is: public static void Main() { System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.GetCultureInfo("en-US"); System.Threading.Thread.CurrentThread.CurrentUICulture = System.Globalization.CultureInfo.GetCultureInfo("en-US"); Process oProc = new Process(); oProc.StartInfo.FileName = "foobar.exe"; oProc.Start(); } Result: Unhandled Exception: System.ComponentModel.Win32Exception: El sistema no puede hallar el archivo especificado at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startI nfo) Any ideas about what I may be doing wrong? Thanks in advance, Andr?s [ knocte ] -- From manfred.braun at manfbraun.de Wed Mar 7 16:49:20 2007 From: manfred.braun at manfbraun.de (manfred.braun) Date: Wed, 7 Mar 2007 22:49:20 +0100 Subject: [Mono-dev] mono-xsp problem:page(s) does not participate in application (global.asax) | Samples Message-ID: Hello again! I modified it a bit and attached two files. a) "global.asax.cs" with a public property and a public method and b) "test3.aspx" which should use them. The error message is: Error message: /tmp/www-data-temp-aspnet-0/b2b914a2/21d07496.0.cs(64,29) : error CS0103: The name `Global' does not exist in the context of `ASP.test3_aspx' /tmp/www-data-temp-aspnet-0/b2b914a2/21d07496.0.cs(66,29) : error CS0103: The name `Global' does not exist in the context of `ASP.test3_aspx' Just to be sure, I am using: Mono Runtime Version: 1.1.4322.2032 Not to mention, in the root, my "global.asax" is as this: <%@Application inherits="Global" src="/bin/Global.asax.cs" %> Best regards, Manfred Note:This is my second attempt to send this message. I end up always getting a message, that the mail will be checked by a moderator first, but my message never appears. I wrote the list-admin, but got no response. -------------- next part -------------- A non-text attachment was scrubbed... Name: test3.aspx Type: application/xml Size: 218 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070307/19824888/attachment.rdf -------------- next part -------------- A non-text attachment was scrubbed... Name: Global.asax.cs Type: application/octet-stream Size: 387 bytes Desc: not available Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070307/19824888/attachment.obj From michael.back.ext at siemens.com Thu Mar 8 04:05:52 2007 From: michael.back.ext at siemens.com (Back, Michael (ext)) Date: Thu, 8 Mar 2007 10:05:52 +0100 Subject: [Mono-dev] Stop Garbage Collection for a Codeblock Message-ID: <003F437218F04842B2A6976FA19368B114A8D9@ERLM863A.ww001.siemens.net> Hi! Is it possible to stop the GC for garbage collecting for a code block? This would be helpful for time critical parts. I think about something like gc_barrierer_on and gc_barrierer_off. If s