[Open Office] VBA: review ...
michael meeks
michael.meeks at novell.com
Tue Sep 6 11:43:45 EDT 2005
So,
I just did a little hacking on the VBA code - and came up with some
feedback:
* This code looks like it's been involved in a nasty crash,
+ inconsistant / ugly formatting
+ broken tab-stops (should be 4stop tabs)
+ cut/paste party
We need to fix the above - this code needs to look like it's been
loved, groomed, had it's nails painted, taken out for a ball, and
massaged until it squeaks.
So - in addition to the above cosmetic cleanup - I looked at
'vbarows.?xx' and 'vbacolumns.?xx' the 'Item' method being a
particularly egregious case of cut/paste.
After considering that - I noticed that in fact 'Columns' and 'Rows'
themselves are 'Ranges' - just 1 dimensional ones - and that really, our
Columns/Rows methods on 'Range' should just shrink the range in that
way. Ideally - that combined with Jody's R1C1 work will allow us to do
things like:
Range("A1:Z256").Rows("3:7")
or
Range("A1:Z256").Rows().Font.Bold = True
As some of the sample VBA out there tends to do ;-)
Any chance we can get Rows / Columns re-factored away - it badly needs
to die ;-) ?
Thanks,
Michael.
--
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the Openoffice
mailing list