[Open Office] Re: Galleries do not work in OOo-2.0.1

[Giuseppe Ghibò]

Giuseppe Ghibò wrote:

> Petr Mladek wrote:
> 
>> Hi,
>>
>> Giuseppe found that there are some problems with galleries in 
>> OOo-2.0.1. I reproduced the same problems with OOO_2_0_1 sources and 
>> ooo-build-2.0.1.
>>
>> The problems are:
>>
>> 1. We use ooo-build/bin/build-galleries script to generate extra 
>> galleries from OpenClipart. The gengal from OOo-2.0.1 puts all 
>> galleries into a single file even when I create galleries with various 
>> names (-name option)
>>
>> 2. OOo-2.0.1 does not show the galleries. It shows empty box when I 
>> select Tools/Gallery in the writer.
>>
>>
>> I do not see the problems with the upstream build, so the problem 
>> probably is in ooo-build. It worked when I built src680-m143 with an 
>> older version of ooo-build.
>>
>> Do you have the same problem?
>>
> 
> FYI, I did another attempt on m148 and yesterday evening
> ooo-build CVS from 2.0head. Same wrong galleries, but this time instead
> of obtaining only the files sg70.{sdg,sdv,thm} I obtain both
> sg70.{sdg,sdv,thm} and sg71.{sdg,sdv,thm}. But note that gengal processed
> galleries:
> 

...

I was going a bit further after you said to look at gallery1.cxx. I applied
this patch in attach on m148 build (with ooobuild 20050105) (with 4.0.1+patches), and I was able 
to get galleries from sg70 to sg87 (except sg71 which fails to
build sg71.sdg, but only sg71.sdv and sd71.thm), and the resulting
binary (but you have to rebuild the whole svx module after the patch)
seems able to open the new galleries.

The same patch applied to 2.0.1 causes gengal to produce only
broken sg70 to sg74 galleries..., so it don't work on 2.0.1.

Note that the patch doesn't do anything particular, it's
just rewrite the line in the source in a less "obfuscated" way,
so probably could be either a compiler bug or still there is
something to look to fix the gallery code (maybe some unitialized
var?).

Bye
Giuseppe.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svx-gengal-galleries-fix.diff
Type: text/x-patch
Size: 802 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/openoffice/attachments/20060107/ae83625b/svx-gengal-galleries-fix.bin