[Open Office] ooo-build --with-vendor configure switch

[Petr Mladek]

On Wednesday 21 June 2006 16:08, Jan Holesovsky wrote:
> On Wednesday 21 June 2006 15:23, Petr Mladek wrote:
> > > suka found out that the new branding thing gets broken when you specify
> > > --with-vendor to ooo-build's configure - that's because the ooo-build's
> > > configure switches are propagated to config_office/configure.
> > >
> > > Now - how to fix it the best way ;-)  I'd like to get rid of the
> > > ooo-build's --with-vendor switch.  It sets a VENDORNAME variable which
> > > seems just to do nearly the same thing as --with-distro - installs
> > > stuff according to the distro.  I propose to change the VENDORNAME
> > > occurrences to use the DISTRO instead.
> > >
> > > Distro maintainers, do you agree with the proposed change, please? ;-)
> >
> > Hmm, the problem is that many ooo-build hacks are vendor specific. Most
> > vendors use more than one distro.
>
> Oh, OK.  So what about to let VENDORNAME as it is, but set it
> programatically based on DISTRO? ;-)  Something like the following in the
> configure.in:
>
> case $DISTRO in
> 	Ark*) VENDORNAME="Ark" ;;
> 	Debian*) VENDORNAME="Debian" ;;
> 	Frugalware*) VENDORNAME="Frugalware" ;;
> 	Mandriva*) VENDORNAME="Mandriva" ;;
> 	SUSE*|Novell*|NLD*) VENDORNAME="Novell" ;;
> 	Ubuntu*) VENDORNAME="Ubuntu" ;;
> 	*) VENDORNAME="$DISTRO" ;;
> esac
>
> Would it be OK?

+1
Sounds good.

Regards,
Petr