<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    Someone replied to the commit/push/pull-request: (paraphrasing from
    memory): "Looks good to me.  Thanks"  --  I don't know whether or
    not that person is a TDS Driver Maintainer or not, though.  That was
    sganesh who apparently also is known as Nagappan if i typed that
    right.<br>
    <br>
    I was thinking of building a test after geting the below message,
    looking at
    <meta http-equiv="content-type" content="text/html;
      charset=ISO-8859-1">
    <a href="http://www.mono-project.com/Test_Suite">http://www.mono-project.com/Test_Suite</a>
    .. And it says to run existing tests, go into class library
    directory (i.e. mcs/class/Mono.Data.Tds or
    mcs/class/Mono.Data.Tds/Mono.Data.Tds.Protocol and run 'make
    run-test' and i did and there were no existing tests in there to
    base a test on.  It would be easier if i had some sample test to
    build on because i've never written a unit test before.<br>
    <br>
    <br>
    On 05/02/2012 07:28 AM, Rodrigo Kumpera wrote:
    <blockquote
cite="mid:CACmR+BAB9oVZ1zbaEq=wAA0A5GSQFr4WO3XsU=5aPKAMu_qz_w@mail.gmail.com"
      type="cite">Patches are much more likely to be accepted if they
      include tests. It's up to the TDS driver maintainers.<br>
      <br>
      <div class="gmail_quote">On Wed, May 2, 2012 at 8:26 AM, Rob
        Wilkens <span dir="ltr"><<a moz-do-not-send="true"
            href="mailto:robwilkens@gmail.com" target="_blank">robwilkens@gmail.com</a>></span>
        wrote:<br>
        <blockquote class="gmail_quote" style="margin:0 0 0
          .8ex;border-left:1px #ccc solid;padding-left:1ex">
          <div bgcolor="#FFFFFF" text="#000000"> [resending reply via
            reply to list only, left off list in previous reply]
            <div class="im"><br>
              <br>
              I already did the pull request on github -- and i'm not
              sure how to include the tests (I only commented that i ran
              the tests on github in the pull comments).  Or do you mean
              i have to somehow generate my own tests, which would be
              difficult because this requires, i think, a functional
              microsoft sql server for it to have access to to reproduce
              the error. <br>
              <br>
              -Rob <br>
              <br>
              On 05/02/2012 07:21 AM, Rodrigo Kumpera wrote: </div>
            <div>
              <div class="h5">
                <blockquote type="cite">Please make it a pull request on
                  github with tests included.
                  <div><br>
                  </div>
                  <div><br>
                    <br>
                    <div class="gmail_quote">On Tue, May 1, 2012 at
                      12:55 PM, Rob Wilkens <span dir="ltr"><<a
                          moz-do-not-send="true"
                          href="mailto:robwilkens@gmail.com"
                          target="_blank">robwilkens@gmail.com</a>></span>
                      wrote:<br>
                      <blockquote class="gmail_quote" style="margin:0 0
                        0 .8ex;border-left:1px #ccc
                        solid;padding-left:1ex">
                        <div bgcolor="#FFFFFF" text="#000000"> <br>
                          Ok, I looked up the 'selfish' way to submit a
                          patch from the contributing section, and i
                          think the below suffices as a patch, does
                          anyone disagree?<br>
                          <br>
                          I am referring to : <a moz-do-not-send="true"
href="http://www.mono-project.com/Contributing" target="_blank">http://www.mono-project.com/Contributing</a>
                          towards the bottom of the page where it simply
                          says to submit the patch to the mailing list.<br>
                          <br>
                          Does the below suffice as a "patch" or should
                          i figure out the 'github' way which i thought
                          i saw elsewhere.<br>
                          <br>
                          -Rob<br>
                          <br>
                          On 05/01/2012 11:49 AM, Rob Wilkens wrote:
                          <blockquote type="cite">
                            <pre>I found out the fix for the error i reported with multiple invalid
login attempts...  It's very simple...

Mono.Data.TdsClient.TdsConnectionPool.cs

In the above file, in GetConnection(), either before:

goto retry

or after the initial

retry:

(either place should be fine)

result needs to be set to null -- that is:

result=null;

(in my testing, i put it before goto retry)

Otherwise, it keeps retrying because result has never been reset
before the while loop you are trying to enter.

I guess my next step is figuring out how to navigate github so i can submit it.

Sorry for being so public and crowding the mailing list with this.  If
someone else wants to volunteer to submit the patch for me, please
speak up.  I'll otherwise figure it out.

-Rob
</pre>
                          </blockquote>
                          <br>
                        </div>
                        <br>
                        _______________________________________________<br>
                        Mono-devel-list mailing list<br>
                        <a moz-do-not-send="true"
                          href="mailto:Mono-devel-list@lists.ximian.com"
                          target="_blank">Mono-devel-list@lists.ximian.com</a><br>
                        <a moz-do-not-send="true"
                          href="http://lists.ximian.com/mailman/listinfo/mono-devel-list"
                          target="_blank">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a><br>
                        <br>
                      </blockquote>
                    </div>
                    <br>
                  </div>
                </blockquote>
                <br>
              </div>
            </div>
          </div>
          <br>
          _______________________________________________<br>
          Mono-devel-list mailing list<br>
          <a moz-do-not-send="true"
            href="mailto:Mono-devel-list@lists.ximian.com">Mono-devel-list@lists.ximian.com</a><br>
          <a moz-do-not-send="true"
            href="http://lists.ximian.com/mailman/listinfo/mono-devel-list"
            target="_blank">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a><br>
          <br>
        </blockquote>
      </div>
      <br>
    </blockquote>
    <br>
  </body>
</html>