<meta content="text/html; charset=ISO-8859-1"
<body bgcolor="#FFFFFF" text="#000000">
After I committed and pushed, I tried to do another pull request,
but it seemed to merge it into my existing pull request, which i
guess is fine. <br>
I'm open to suggestions if anyone doesn't like my pull-request.
Don't mean to push the issue, however long it takes is however long
I am well aware that it could be quite some time before this patch
reaches my local system via packaging.. There is probably a review
process before you accept it or not, some time before the next
version is released, and some time beyond that before ubuntu
releases an updated package which includes it.<br>
On 05/03/2012 07:46 AM, Rodrigo Kumpera wrote:
type="cite">Separate is fine. Tests are always welcome.
<div>Thanks for taking time on this.</div>
<div class="gmail_quote">On Wed, May 2, 2012 at 11:10 PM, Rob
Wilkens <span dir="ltr"><<a moz-do-not-send="true"
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I came up
with a Nunit test that :<br>
(1) Demonstrates the failure i reported<br>
(2) Demonstrates that it is fixed with my patch<br>
(My git directory is separate from my build directory)<br>
My plan, if i remember tomorrow, is to commit this change to
github, push it, and do another pull request.<br>
Do i need to incorporate it into the same pull request as
the fix itself, or is it ok to do the tests as a separate
If i don't hear back, i'll just assume separate is ok.<br>
Mono-devel-list mailing list<br>