<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "><span>Yeah, I get target-fixation too sometimes. :-)</span></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "><span><br></span></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "><span>I only see three failing WinForms tests currently:</span></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "><span><br></span></div><div><span><div>1) MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataMemberBeforeDataSource : System.ArgumentException : dataMember</div><div>at System.Windows.Forms.ListBindingHelper.GetList (System.Object dataSource, System.String dataMember) [0x00107] in
 /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ListBindingHelper.cs:81</div><div>at System.Windows.Forms.BindingSource.ResetList () [0x0000c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:140</div><div>at System.Windows.Forms.BindingSource.set_DataSource (System.Object value) [0x0003c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:353</div><div>at (wrapper remoting-invoke-with-check) System.Windows.Forms.BindingSource:set_DataSource (object)</div><div>at MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataMemberBeforeDataSource () [0x0002c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/BindingSourceTest.cs:804</div><div>at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke
 (System.Reflection.MonoMethod,object,object[],System.Exception&)</div><div>at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229</div><div><br></div><div>2) MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataSourceAssignToDefaultType : System.ArgumentException : dataMember</div><div>at System.Windows.Forms.ListBindingHelper.GetList (System.Object dataSource, System.String dataMember) [0x00107] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ListBindingHelper.cs:81</div><div>at System.Windows.Forms.BindingSource.ResetList () [0x0000c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:140</div><div>at
 System.Windows.Forms.BindingSource.set_DataSource (System.Object value) [0x0003c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:353</div><div>at (wrapper remoting-invoke-with-check) System.Windows.Forms.BindingSource:set_DataSource (object)</div><div>at MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataSourceAssignToDefaultType () [0x0003e] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/BindingSourceTest.cs:815</div><div>at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)</div><div>at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in
 /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229</div><div><br></div><div>3) MonoTests.System.Windows.Forms.DataBinding.CurrencyManagerTest2.TestInsertRowAtCurrent :   2</div><div>  String lengths are both 112. Strings differ at index 91.</div><div>  Expected: "...ged (index = -1)\n3: PositionChanged (to 2)\n4: Binding.Format\n"</div><div>  But was:  "...ged (index = -1)\n3: PositionChanged (to 1)\n4: Binding.Format\n"</div><div>  -------------------------------------------------------^</div><div><br></div><div>at MonoTests.System.Windows.Forms.DataBinding.CurrencyManagerTest2.TestInsertRowAtCurrent () [0x00161] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/DataBindingTests.cs:552</div><div>at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)</div><div>at
 System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229</div></span></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "><br></div>  <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "> <div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt; "> <div dir="ltr"> <font size="2" face="Arial"> <hr size="1">  <b><span style="font-weight:bold;">From:</span></b> Stifu <stifu@free.fr><br> <b><span style="font-weight: bold;">To:</span></b> mono-devel-list@lists.ximian.com <br> <b><span style="font-weight: bold;">Sent:</span></b> Sunday, July 29, 2012 11:04 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re:
 [Mono-dev] Patches for mono-winforms<br> </font> </div> <br>
Ah, thanks for the fix. It's in. I overlooked these regressions as I was<br>solely focused on the new test.<br>Out of curiosity, do you also see 5 remaining failing WinForms tests?<br><br>Steven Boswell II wrote<br>> <br>> The following patch fixes the two recently-broken WinForms unit tests.<br>> Stifu?  You checked in ermshiperete's change without running unit tests?<br><br> </div> </div>  </div></body></html>