<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Caqn you provide a test case/code which demonstrates the deadlock? 
    That would be beneficial, otherwise i do not see the BUG IN MONO TCP
    ASYNC process getting fixed any time soon, which is more then a
    complete bummer, its a complete mess.<br>
    <br>
    Shawn<br>
    <br>
    <div class="moz-cite-prefix">On 11/29/2012 5:50 PM, Rodrigo Kumpera
      wrote:<br>
    </div>
    <blockquote
cite="mid:CACmR+BA8Uhzu4KuCO0Y0afC6YAik9Dmmm6vbkZPtJCDPx-DwGA@mail.gmail.com"
      type="cite"><br>
      <div class="gmail_extra"><br>
        <br>
        <div class="gmail_quote">On Thu, Nov 29, 2012 at 5:06 PM, james
          <span dir="ltr"><<a moz-do-not-send="true"
              href="mailto:james@mansionfamily.plus.com" target="_blank">james@mansionfamily.plus.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">I don't
            buy it.  You knew who it was from.<br>
          </blockquote>
          <div><br>
          </div>
          <div>This was never questioned.</div>
          <div>
             </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            If there were issues with justification in the documentation
            with the original patch set, surely that should be dealt
            with at the time it was pulled in?<br>
          </blockquote>
          <div><br>
          </div>
          <div>No explanation on why the patch worked was given. "It
            improves stability" was the closest I got. Given the patch
            was vouched by the previous maintainer</div>
          <div>of that code base it was merged.</div>
          <div><br>
          </div>
          <div>A deadlock on the code was found, so I reverted it. Greg
            is free to do a pull request on an patch that fixes the
            deadlock and has a proper explanation.</div>
          <div>
            <br>
          </div>
          <div><br>
          </div>
          <div> </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            You appear to be saying that:<br>
             - patches are applied without discussion, and without
            adequate justification on the ticket (were they checked in
            against a ticket?)<br>
          </blockquote>
          <div><br>
          </div>
          <div>The patch was discussed ad-nausea on this mailing list
            and on the github pull request. You can look for both, both
            happened in the public.</div>
          <div><br>
          </div>
          <div> </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
             - patches were reverted without any discussion with the
            author (was THAT against a ticket?)</blockquote>
          <div><br>
          </div>
          <div>Bad patches are reverted. There was no ticket, just a
            pull request on github. Greg's test could not be reproduced
            outside of his environment.<br>
          </div>
          <div><br>
          </div>
          <div>  </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            What is the process supposed to be? IS there a process?<br>
          </blockquote>
          <div> </div>
          <div>Good code shaped in proper patches go in. Bad code goes
            out. It is that simple.</div>
          <div><br>
          </div>
          <div><br>
          </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            Isn't this concerning?  TCP/IP performance and async IO is
            rather important to anyone doing server apps.</blockquote>
          <div><br>
          </div>
          <div><br>
          </div>
          <div>I have no idea on what you're talking anymore. That there
            are bugs, or that I broken patch was merged in?</div>
          <div><br>
          </div>
          <div><br>
          </div>
          <div><br>
          </div>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Mono-devel-list mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Mono-devel-list@lists.ximian.com">Mono-devel-list@lists.ximian.com</a>
<a class="moz-txt-link-freetext" href="http://lists.ximian.com/mailman/listinfo/mono-devel-list">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>