<div dir="ltr">Hey,<div><br></div><div>I have a variation of this patch now.   I need to rebuild my Mono before i can commit it.</div><div><br>It will use a conditional compiler directive to use this other system</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 8, 2014 at 11:53 PM, Stephen Shaw <span dir="ltr"><<a href="mailto:sshaw@decriptor.com" target="_blank">sshaw@decriptor.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I can't comment on the code changes themselves, but it would be helpful to fork mono on github and then create a Pull Request (PR) with your changes.<div><br></div><div>Cheers,</div><div>Stephen<br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Mon, Dec 8, 2014 at 8:54 PM, Michael McGlothlin <span dir="ltr"><<a href="mailto:mike.mcglothlin@gmail.com" target="_blank">mike.mcglothlin@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div>Couldn't figure out how to get Xamarin Studio to create an actual patch file after trying, and failing, to push a change with git. It appears this is the correct place to post this?</div><div><br></div><div><div>I usually put most of my code in PCL and then call it from platform specific code so I'm trying to make DataConverter happy as PCL.</div></div><div><br></div><div>To make DataConverter compile as PCL I had to change Encoding.UTF7 to Encoding.GetEncoding ( "utf-7" ) and the numeric calls to 12000 and 12001 on GetEncoding() to the string-based "utf-32" and "uff-32BE". These three changes had to be made twice as there are two variants using this same code. I also changed ArrayList to List<object> to make PCL happy.</div><div><br></div><div><br></div><div><br></div><div><div><font face="monospace"><span style="white-space:pre-wrap">                         </span>case '7':</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                    </span>e = Encoding.GetEncoding ("utf-7");</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                        </span>n = 1;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                       </span>break;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                               </span>case '3':<br></font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                  </span>e = Encoding.GetEncoding ("utf-32");</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                       </span>n = 4;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                       </span>break;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                               </span>case '4':</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                    </span>e = Encoding.GetEncoding ("utf-32BE");</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                     </span>n = 4;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                                       </span>break;</font></div><div><span style="white-space:pre-wrap"><font face="monospace"><br></font></span></div><div><span style="white-space:pre-wrap"><font face="monospace"><br></font></span></div><div><span style="white-space:pre-wrap"><font face="monospace"><br></font></span></div><div><font face="monospace"><span style="white-space:pre-wrap">                </span>static public IList Unpack (string description, byte[] buffer, int startIndex)<br></font></div><div><font face="monospace"><span style="white-space:pre-wrap">             </span>{</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                    </span>DataConverter conv = CopyConv;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                       </span>var result = new List<object> ();</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                      </span>int idx = startIndex;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                        </span>bool align = false;</font></div><div><font face="monospace"><span style="white-space:pre-wrap">                  </span>int repeat = 0, n;</font></div><div><br></div></div></div>
<br></div></div>_______________________________________________<br>
Mono-devel-list mailing list<br>
<a href="mailto:Mono-devel-list@lists.ximian.com" target="_blank">Mono-devel-list@lists.ximian.com</a><br>
<a href="http://lists.ximian.com/mailman/listinfo/mono-devel-list" target="_blank">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
Mono-devel-list mailing list<br>
<a href="mailto:Mono-devel-list@lists.ximian.com">Mono-devel-list@lists.ximian.com</a><br>
<a href="http://lists.ximian.com/mailman/listinfo/mono-devel-list" target="_blank">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a><br>
<br></blockquote></div><br></div>