[Moonlight-list] UIElement::UseBackToFront confusion..

David Reveman davidr at novell.com
Wed Nov 18 14:29:37 EST 2009


fix attached.. we might want to play with the value of
MIN_FRONT_TO_BACK_COUNT a bit. I don't really see the purpose of this
value at all and would just like it to be 0 but I guess it was added for
a reason..

- david

On Tue, 2009-11-17 at 20:34 -0500, David Reveman wrote:
> function currently looks like this:
> 
> bool
> UIElement::UseBackToFront ()
> {
> 	return VisualTreeWalker (this).GetCount () < MIN_FRONT_TO_BACK_COUNT;
> }
> 
> which seems fine but it's used as if the result it would return is that
> of a function called UseFrontToBack. example:
> 
> runtime.cpp:	bool front_to_back = uielement->UseBackToFront ();
> uielement.cpp:	if (!UseBackToFront ()) {
> 
> the use of the function seems wrong to me.. i would simply change it to:
> 
> runtime.cpp: bool front_to_back = !uielement->UseBackToFront ();
> uielement.cpp: if (UseBackToFront ()) {
> 
> but that means that the current use of "front-to-back" rendering is
> pretty broken.. what is the logic behind this?
> is MIN_FRONT_TO_BACK_COUNT supposed to be the minimum number of
> children required for front-to-back rendering or is it the other way
> around?
> 
> - david
> 
> 
> _______________________________________________
> Moonlight-list mailing list
> Moonlight-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/moonlight-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: moon-fix-use-back-to-front.diff
Type: text/x-patch
Size: 826 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/moonlight-list/attachments/20091118/f2e9165c/attachment.bin 


More information about the Moonlight-list mailing list